From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 17 Feb 2025 15:56:50 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tk2YE-003WTW-1v for lore@lore.pengutronix.de; Mon, 17 Feb 2025 15:56:50 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tk2YD-0001lM-Dx for lore@pengutronix.de; Mon, 17 Feb 2025 15:56:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VPEWzIs/WRyP487rgl3vzvwXeR5yIeK5xlh7Ntw1jsM=; b=eGYIcvUvvB3Vw+lMRaynTPq2vN hij21DBTWtOyBJ1VMoVJ0d+W3WMw5boN5fENVIKrWMLIdEirUbECqFflbTEPEZnq/eb+JI4bkrItM 0Q8TtP6/9XtyuEUZy1FNYfXwHxC7ciGxzzjqPm2PRZclNCnd3pswQnIjhZq0UXi0OfmMhIPotUY7M jNuEdy7L92uFs5zHfyPab227JFZD2Ls5HuYlT8hEAmQEZ1OKDEZIDuonUUpVZLihXHTBCjHPuCGsm 97cLMfnssuWPBVpf6gBC7cddw00xKC9m8z2wrRVljBZM9gjmRcK8Ycdfzaxm/J1c7CLEGGlZNQixI CxOANGOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tk2Xn-00000004wxS-2jNk; Mon, 17 Feb 2025 14:56:23 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tk2NX-00000004upJ-3h9w for barebox@lists.infradead.org; Mon, 17 Feb 2025 14:45:49 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tk2NW-0008L4-K1; Mon, 17 Feb 2025 15:45:46 +0100 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tk2NW-001QdZ-1P; Mon, 17 Feb 2025 15:45:46 +0100 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tk2NW-007SV2-14; Mon, 17 Feb 2025 15:45:46 +0100 From: Sascha Hauer To: Barebox List Date: Mon, 17 Feb 2025 15:45:43 +0100 Message-Id: <20250217144543.1777605-2-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250217144543.1777605-1-s.hauer@pengutronix.de> References: <20250217144543.1777605-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250217_064547_918337_3760E397 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 2/2] usb: dwc3: am62: set mode valid bit before probing children X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) We should fully configure the desired register settings before calling of_platform_populate() to make sure they actually have an effect. Signed-off-by: Sascha Hauer --- drivers/usb/dwc3/dwc3-am62.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c index 7dac8981fb..848549fbf6 100644 --- a/drivers/usb/dwc3/dwc3-am62.c +++ b/drivers/usb/dwc3/dwc3-am62.c @@ -240,17 +240,17 @@ static int dwc3_ti_probe(struct device *dev) clk_prepare_enable(am62->usb2_refclk); + /* Set mode valid bit to indicate role is valid */ + reg = dwc3_ti_readl(am62, USBSS_MODE_CONTROL); + reg |= USBSS_MODE_VALID; + dwc3_ti_writel(am62, USBSS_MODE_CONTROL, reg); + ret = of_platform_populate(node, NULL, dev); if (ret) { dev_err_probe(dev, ret, "failed to create dwc3 core\n"); goto err_pm_disable; } - /* Set mode valid bit to indicate role is valid */ - reg = dwc3_ti_readl(am62, USBSS_MODE_CONTROL); - reg |= USBSS_MODE_VALID; - dwc3_ti_writel(am62, USBSS_MODE_CONTROL, reg); - return 0; err_pm_disable: -- 2.39.5