From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] fixup! complete: give device_param_complete a flags parameter
Date: Thu, 27 Mar 2025 08:48:14 +0100 [thread overview]
Message-ID: <20250327074814.3714019-1-a.fatoum@pengutronix.de> (raw)
When completing an existing variable, we want a trailing assignment, so
the use can just start typing the value.
This was the behavior before the commit being fixed up broke it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/complete.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/complete.c b/common/complete.c
index 6cb674a0cc9c..5327944ca93b 100644
--- a/common/complete.c
+++ b/common/complete.c
@@ -469,7 +469,7 @@ int complete(char *instr, char **outstr)
} else {
command_complete(&sl, instr);
path_command_complete(&sl, instr);
- env_param_complete(&sl, instr, 0);
+ env_param_complete(&sl, instr, DEVPARAM_COMPLETE_ASSIGNMENT);
}
if (*instr == '$')
env_param_complete(&sl, instr + 1, DEVPARAM_COMPLETE_DOLLAR);
--
2.39.5
next reply other threads:[~2025-03-27 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 7:48 Ahmad Fatoum [this message]
2025-03-27 9:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327074814.3714019-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox