From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 2/3] common: pe: fix crash when pe_load was not called
Date: Fri, 4 Apr 2025 17:55:20 +0200 [thread overview]
Message-ID: <20250404155521.2863158-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20250404155521.2863158-1-a.fatoum@pengutronix.de>
pe_close is the counterpart to pe_open. pe->code is set to non-NULL
outside pe_open by pe_load, so we should check for NULL before
attempting to free the SDRAM region.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/pe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/pe.c b/common/pe.c
index 65d456a2c332..fd99761bddfd 100644
--- a/common/pe.c
+++ b/common/pe.c
@@ -373,7 +373,8 @@ int pe_load(struct pe_image *pe)
void pe_close(struct pe_image *pe)
{
- release_sdram_region(pe->code);
+ if (pe->code)
+ release_sdram_region(pe->code);
free(pe->bin);
free(pe);
}
--
2.39.5
next prev parent reply other threads:[~2025-04-04 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 15:55 [PATCH master 1/3] fs: add only successful filesystem probes to fs_device_list Ahmad Fatoum
2025-04-04 15:55 ` Ahmad Fatoum [this message]
2025-04-04 15:55 ` [PATCH master 3/3] barebox.h: annotate __hang as __noreturn Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404155521.2863158-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox