From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/2] clocksource: timer-ti-dm: replace magic constant with descriptive macros
Date: Tue, 29 Apr 2025 15:25:49 +0200 [thread overview]
Message-ID: <20250429132550.3768805-1-a.fatoum@pengutronix.de> (raw)
This improves readability a bit, but introduces no functional change.
Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/clocksource/timer-ti-dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index 1090b96a0e94..572ea2fdc945 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -37,6 +37,8 @@
#define IRQSTATUS_CLR 0x30
#define IRQWAKEEN 0x34
#define TCLR 0x38
+#define TCLR_START BIT(0) /* Start=1 */
+#define TCLR_AUTO_RELOAD BIT(1) /* Auto reload */
#define TCRR 0x3C
#define TLDR 0x40
#define TTGR 0x44
@@ -76,7 +78,7 @@ int omap_dmtimer_init(void __iomem *mmio_start, unsigned clk_speed)
dmtimer_cs.mult = clocksource_hz2mult(clk_speed, dmtimer_cs.shift);
/* Enable counter */
- writel(0x3, base + TCLR);
+ writel(TCLR_START | TCLR_AUTO_RELOAD, base + TCLR);
return init_clock(&dmtimer_cs);
}
--
2.39.5
next reply other threads:[~2025-04-29 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:25 Ahmad Fatoum [this message]
2025-04-29 13:25 ` [PATCH 2/2] clocksource: timer-ti-dm: adapt omap_dmtimer_init parameter type to usage Ahmad Fatoum
2025-04-29 15:04 ` [PATCH 1/2] clocksource: timer-ti-dm: replace magic constant with descriptive macros Sascha Hauer
2025-04-29 19:46 ` Daniel Lezcano
2025-04-29 21:49 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429132550.3768805-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=daniel.lezcano@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox