mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 6/9] PBL: fdt: add fdt_fixup_mem to fixup memory nodes
Date: Mon, 26 May 2025 16:38:12 +0200	[thread overview]
Message-ID: <20250526-rk3588-optee-v1-6-5004995cbd03@pengutronix.de> (raw)
In-Reply-To: <20250526-rk3588-optee-v1-0-5004995cbd03@pengutronix.de>

Board code in the PBL may use fdt_fixup_mem() to write the base
addresses and sizes of detected SDRAM to the fdt before passing the fdt
to other software like the TF-A and OP-TEE.

This is implemented on the fdt to avoid that the PBL needs to unpack the
device tree, use the of function for manipulation and repack the device
tree.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 include/pbl.h |  1 +
 pbl/fdt.c     | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+)

diff --git a/include/pbl.h b/include/pbl.h
index abac3458593af2cec972a54ce9fb69e344179670..b330010562c4aba5fccbb4c421bb95291fa0bea1 100644
--- a/include/pbl.h
+++ b/include/pbl.h
@@ -17,6 +17,7 @@ extern unsigned long free_mem_end_ptr;
 void pbl_barebox_uncompress(void *dest, void *compressed_start, unsigned int len);
 
 void fdt_find_mem(const void *fdt, unsigned long *membase, unsigned long *memsize);
+int fdt_fixup_mem(void *fdt, unsigned long membase[], unsigned long memsize[], size_t num);
 
 struct fdt_device_id {
 	const char *compatible;
diff --git a/pbl/fdt.c b/pbl/fdt.c
index 3b1783152a8cb81f3eda1187b2f7bf998c4addf4..40564952acfcd88bef050966720e76b7378bc720 100644
--- a/pbl/fdt.c
+++ b/pbl/fdt.c
@@ -2,6 +2,7 @@
 #include <linux/libfdt.h>
 #include <pbl.h>
 #include <linux/printk.h>
+#include <stdio.h>
 
 static const __be32 *fdt_parse_reg(const __be32 *reg, uint32_t n,
 				   uint64_t *val)
@@ -73,6 +74,76 @@ void fdt_find_mem(const void *fdt, unsigned long *membase, unsigned long *memsiz
 	while (1);
 }
 
+int fdt_fixup_mem(void *fdt, unsigned long membase[], unsigned long memsize[], size_t num)
+{
+	int na, ns;
+	int node, root;
+	int err;
+	int i;
+
+	err = fdt_check_header(fdt);
+	if (err != 0) {
+		pr_err("Invalid device tree blob\n");
+		return err;
+	}
+
+	root = fdt_path_offset(fdt, "/");
+	if (root < 0) {
+		pr_err("Cannot find root node: %s\n", fdt_strerror(root));
+		return root;
+	}
+
+	na = fdt_address_cells(fdt, root);
+	if (na < 0) {
+		pr_err("Cannot find #address-cells property: %s\n",
+		       fdt_strerror(na));
+		return na;
+	}
+
+	ns = fdt_size_cells(fdt, root);
+	if (ns < 0) {
+		pr_err("Cannot find #size-cells property: %s\n",
+				fdt_strerror(ns));
+		return ns;
+	}
+
+	for (i = 0; i < num; i++) {
+		char name[32];
+
+		if (membase[i] == 0 || memsize[i] == 0)
+			continue;
+
+		snprintf(name, sizeof(name), "memory@%lx", membase[i]);
+		node = fdt_add_subnode(fdt, root, name);
+		if (node < 0) {
+			pr_err("Cannot to add node %s: %s\n",
+			       name, fdt_strerror(node));
+			err = node;
+			break;
+		}
+
+		pr_debug("Add memory node %s (0x%lx, size 0x%lx)\n",
+			 name, membase[i], memsize[i]);
+
+		err = fdt_setprop(fdt, node,
+				  "device_type", "memory", sizeof("memory"));
+		if (err < 0) {
+			pr_err("%s: Cannot set device_type: %s\n",
+			       name, fdt_strerror(err));
+			return err;
+		}
+
+		err = fdt_appendprop_addrrange(fdt, root, node, "reg", membase[i], memsize[i]);
+		if (err < 0) {
+			pr_err("Failed to fixup memory %lx %lx: %s\n",
+			       membase[i], memsize[i], fdt_strerror(err));
+			continue;
+		}
+	}
+
+	return err;
+}
+
 const void *fdt_device_get_match_data(const void *fdt, const char *nodepath,
 				      const struct fdt_device_id ids[])
 {

-- 
2.39.5




  parent reply	other threads:[~2025-05-26 14:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 14:38 [PATCH 0/9] ARM: rockchip: fix dynamic shared memory in OP-TEE Michael Tretter
2025-05-26 14:38 ` [PATCH 1/9] ARM: rockchip: fix formatting Michael Tretter
2025-05-26 17:30   ` Marco Felsch
2025-05-26 14:38 ` [PATCH 2/9] ARM: rockchip: dmc: use RK3588_INT_REG_START for rk3588 Michael Tretter
2025-05-26 17:29   ` Marco Felsch
2025-05-26 14:38 ` [PATCH 3/9] lib: fdt: add fdt_addresses Michael Tretter
2025-05-26 17:29   ` Marco Felsch
2025-05-26 14:38 ` [PATCH 4/9] PBL: fdt: refactor helper for reading nr of cells Michael Tretter
2025-05-26 17:30   ` Marco Felsch
2025-05-26 14:38 ` [PATCH 5/9] PBL: fdt: make minimum fdt size configurable Michael Tretter
2025-05-27  6:41   ` Sascha Hauer
2025-05-27  8:48     ` Michael Tretter
2025-05-27 18:45       ` Sascha Hauer
2025-05-28  8:24         ` Michael Tretter
2025-05-26 14:38 ` Michael Tretter [this message]
2025-05-27  6:22   ` [PATCH 6/9] PBL: fdt: add fdt_fixup_mem to fixup memory nodes Sascha Hauer
2025-05-27  8:34     ` Michael Tretter
2025-05-27 18:51       ` Sascha Hauer
2025-05-26 14:38 ` [PATCH 7/9] ARM: rockchip: dmc: add rk3588_ram_sizes to get full ram size Michael Tretter
2025-05-26 16:33   ` Marco Felsch
2025-05-27  6:25     ` Sascha Hauer
2025-05-27  8:39       ` Michael Tretter
2025-05-27  9:06         ` Marco Felsch
2025-05-26 14:38 ` [PATCH 8/9] ARM: rockchip: pass device tree to TF-A Michael Tretter
2025-05-26 16:37   ` Marco Felsch
2025-05-27  8:03     ` Michael Tretter
2025-05-26 14:38 ` [PATCH 9/9] ARM: rockchip: fixup memory in device tree for TF-A Michael Tretter
2025-05-26 17:25   ` Marco Felsch
2025-05-27  8:16     ` Michael Tretter
2025-05-27  9:40       ` Marco Felsch
2025-05-27 10:19         ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250526-rk3588-optee-v1-6-5004995cbd03@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox