From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 05 Jun 2025 09:49:42 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uN5M6-003w8d-2D for lore@lore.pengutronix.de; Thu, 05 Jun 2025 09:49:42 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uN5M5-0007lm-7h for lore@pengutronix.de; Thu, 05 Jun 2025 09:49:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fMG8I6ZugeAYMYn3OJmsXNQ01Y2PCBaqWN2t3XdFIoI=; b=UoZBckSoVRLStOZ+yhuT8pN2cQ ZnStCBhAAWunetcyFL4scfD1Dw7rKML1oIhBN7PdwNSK43i1ROayJP0OOwAUpc4evdk6YTM3jKeCU vMaQhihFwk0iMPgZSnnDtUTymCcOy84SXfi4YEx9tpdO9UD9r8eX+Gzo9XCKX7jLzv2rwUpiUFnIe bRWYAnYrcJgwu55E+4hG266Gh7cfRcrsZGXxeNmEKPf2icHSZTjJsxij/RjOPMLHxM4eOiMW5wxaO HEcuj+KMY9/BFJYO+8s8M8FktXKy4UZgD/bfBh3FWfZxcZsoatFhDiHoJqs/9cOLoXdoKqk55Ttey HTsfEHOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uN5LZ-0000000Ez71-0uud; Thu, 05 Jun 2025 07:49:09 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uN5Jk-0000000Eys0-1g63 for barebox@lists.infradead.org; Thu, 05 Jun 2025 07:47:24 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uN5Ji-00065R-DP; Thu, 05 Jun 2025 09:47:14 +0200 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uN5Ji-001v7y-08; Thu, 05 Jun 2025 09:47:14 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uN5Jh-00HUu9-3A; Thu, 05 Jun 2025 09:47:13 +0200 From: Oleksij Rempel To: barebox@lists.infradead.org Cc: Oleksij Rempel Date: Thu, 5 Jun 2025 09:47:05 +0200 Message-Id: <20250605074713.4170334-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250605074713.4170334-1-o.rempel@pengutronix.de> References: <20250605074713.4170334-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250605_004716_501118_AB8CD8E8 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, SUBJECT_IN_BLACKLIST,SUBJECT_IN_BLOCKLIST autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 1/9] nvmem: Add 'protect' operation to core framework X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Introduce a generic "protect" operation to the NVMEM framework. This allows NVMEM providers to expose hardware-specific protection or locking mechanisms through the character device interface. Existing read/write operations do not cover this type of state-altering protection. Signed-off-by: Oleksij Rempel --- changes v2: - rebase against latest nvmem changes - use (offset + count > nvmem->size) instead of (offset >= nvmem->size || count > nvmem->size - offset) - remove NVMEM_PROTECT_ENABLE_WRITE and NVMEM_PROTECT_DISABLE_WRITE they will be added later as non nvmem specific defines --- drivers/nvmem/core.c | 32 ++++++++++++++++++++++++++++++++ drivers/nvmem/partition.c | 7 +++++++ include/linux/nvmem-provider.h | 2 ++ 3 files changed, 41 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index fd3c39fd8e43..cfe9770a5f1b 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -30,6 +30,8 @@ struct nvmem_device { const void *val, size_t val_size); int (*reg_read)(void *ctx, unsigned int reg, void *val, size_t val_size); + int (*reg_protect)(void *ctx, unsigned int reg, + size_t bytes, int prot); }; struct nvmem_cell { @@ -87,9 +89,38 @@ static ssize_t nvmem_cdev_write(struct cdev *cdev, const void *buf, size_t count return retlen; } +static int nvmem_cdev_protect(struct cdev *cdev, size_t count, loff_t offset, + int prot) +{ + struct nvmem_device *nvmem; + + nvmem = container_of(cdev, struct nvmem_device, cdev); + + dev_dbg(cdev->dev, "protect ofs: 0x%08llx count: 0x%08zx prot: %d\n", + offset, count, prot); + + if (!nvmem->reg_protect) { + dev_warn(cdev->dev, "NVMEM device %s does not support protect operation\n", + nvmem->name); + return -EOPNOTSUPP; + } + + if (!count) + return 0; + + if (offset + count > nvmem->size) { + dev_err(cdev->dev, "protect range out of bounds (ofs: 0x%08llx, count 0x%08zx, size 0x%08zx)\n", + offset, count, nvmem->size); + return -EINVAL; + } + + return nvmem->reg_protect(nvmem->priv, offset, count, prot); +} + static struct cdev_operations nvmem_chrdev_ops = { .read = nvmem_cdev_read, .write = nvmem_cdev_write, + .protect = nvmem_cdev_protect, }; static int nvmem_register_cdev(struct nvmem_device *nvmem, const char *name) @@ -207,6 +238,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->dev.parent = config->dev; nvmem->reg_read = config->reg_read; nvmem->reg_write = config->reg_write; + nvmem->reg_protect = config->reg_protect; np = config->cdev ? cdev_of_node(config->cdev) : config->dev->of_node; nvmem->dev.of_node = np; nvmem->priv = config->priv; diff --git a/drivers/nvmem/partition.c b/drivers/nvmem/partition.c index d1127c1401af..bb6dbad7b5f6 100644 --- a/drivers/nvmem/partition.c +++ b/drivers/nvmem/partition.c @@ -18,6 +18,12 @@ static int nvmem_cdev_read(void *ctx, unsigned offset, void *buf, size_t bytes) return cdev_read(ctx, buf, bytes, offset, 0); } +static int nvmem_cdev_protect(void *ctx, unsigned int offset, size_t bytes, + int prot) +{ + return cdev_protect(ctx, bytes, offset, prot); +} + static int nvmem_cells_probe(struct device *dev) { struct nvmem_config config = {}; @@ -37,6 +43,7 @@ static int nvmem_cells_probe(struct device *dev) config.size = cdev->size; config.reg_read = nvmem_cdev_read; config.reg_write = nvmem_cdev_write; + config.reg_protect = nvmem_cdev_protect; return PTR_ERR_OR_ZERO(nvmem_register(&config)); } diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h index c1765673eb23..4d44468456f0 100644 --- a/include/linux/nvmem-provider.h +++ b/include/linux/nvmem-provider.h @@ -34,6 +34,8 @@ struct nvmem_config { const void *val, size_t val_size); int (*reg_read)(void *ctx, unsigned int reg, void *val, size_t val_size); + int (*reg_protect)(void *ctx, unsigned int offset, + size_t bytes, int prot); void *priv; nvmem_cell_post_process_t cell_post_process; }; -- 2.39.5