From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/2] of: fdt: fix length comparison
Date: Thu, 5 Jun 2025 13:26:06 +0200 [thread overview]
Message-ID: <20250605112607.1970520-1-a.fatoum@pengutronix.de> (raw)
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
If haystack_len equals needle_len the following memcmp would overflow,
because needle_len is incremented in the memcmp.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 43bb73b7a2df..5eead271edb7 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -698,7 +698,7 @@ static int fdt_string_is_compatible(const char *haystack, int haystack_len,
const char *p;
int index = 0;
- while (haystack_len >= needle_len) {
+ while (haystack_len > needle_len) {
if (memcmp(needle, haystack, needle_len + 1) == 0)
return OF_DEVICE_COMPATIBLE_MAX_SCORE - (index << 2);
--
2.39.5
next reply other threads:[~2025-06-05 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:26 Ahmad Fatoum [this message]
2025-06-05 11:26 ` [PATCH 2/2] of: fdt: verify length within bounds before using it Ahmad Fatoum
2025-06-05 11:57 ` [PATCH 1/2] of: fdt: fix length comparison Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605112607.1970520-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox