From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 05 Jun 2025 13:37:12 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uN8uG-003zib-0g for lore@lore.pengutronix.de; Thu, 05 Jun 2025 13:37:12 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uN8uA-0000SB-Ro for lore@pengutronix.de; Thu, 05 Jun 2025 13:37:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5eNsbqnRANvePfcQj49xStzPGItJzDtyFWms2LYkWdw=; b=tOd5vM38s8LO0D172rb1AK7DOe r8+0ff0xl3WnDsGxbPVagN+XcvymAGjPNQ1BE6TZVZiPHpm/QOVI1Jem9jjj1XW2kNq8gBpOZBNeo xzHCc/aFZoxEZRRqJUPgDPX6rj65Jlul6DBGDZZWKdqALOCTSrAoF4Q9HGJYhTrC7KtgKOCjUZIL7 8woDk5OkuevcQhAlB3uFR0JiP5ddYsET90Kfu97ziOl0W2TMVD0DVktd6Eey6yozohCyQvCbuWQAz 47BBgu6CEfdPNe1lWdrRDWT6PdyZb5CxU8eUClMb/M74nXEBEQQmpQdXGBAooKVgQY0gM1R+fqW4T UXOvXZ9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uN8tW-0000000FNH9-2UwG; Thu, 05 Jun 2025 11:36:26 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uN8ja-0000000FMLq-0z4g for barebox@lists.infradead.org; Thu, 05 Jun 2025 11:26:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uN8jY-0001ac-U5; Thu, 05 Jun 2025 13:26:08 +0200 Received: from dude06.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::5c]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uN8jY-001wu8-2O; Thu, 05 Jun 2025 13:26:08 +0200 Received: from localhost ([::1] helo=dude06.red.stw.pengutronix.de) by dude06.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1uN8jZ-008GwF-0z; Thu, 05 Jun 2025 13:26:08 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 5 Jun 2025 13:26:06 +0200 Message-Id: <20250605112607.1970520-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250605_042610_283964_5B218E09 X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 1/2] of: fdt: fix length comparison X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) From: Steffen Trumtrar If haystack_len equals needle_len the following memcmp would overflow, because needle_len is incremented in the memcmp. Signed-off-by: Steffen Trumtrar Signed-off-by: Ahmad Fatoum --- drivers/of/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 43bb73b7a2df..5eead271edb7 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -698,7 +698,7 @@ static int fdt_string_is_compatible(const char *haystack, int haystack_len, const char *p; int index = 0; - while (haystack_len >= needle_len) { + while (haystack_len > needle_len) { if (memcmp(needle, haystack, needle_len + 1) == 0) return OF_DEVICE_COMPATIBLE_MAX_SCORE - (index << 2); -- 2.39.5