From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] fixup! bootm: booti: make device tree optional
Date: Thu, 12 Jun 2025 10:18:09 +0200 [thread overview]
Message-ID: <20250612081809.4170727-1-a.fatoum@barebox.org> (raw)
bootm_get_devicetree returns the fixed up device tree, so it must be
called after bootm_load_initrd, so the properties indicating the initrd
location are included in the fixed DT.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
common/booti.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/common/booti.c b/common/booti.c
index 2d4cb3598737..6a87b84c0308 100644
--- a/common/booti.c
+++ b/common/booti.c
@@ -66,12 +66,6 @@ void *booti_load_image(struct image_data *data, phys_addr_t *oftree)
unsigned long devicetree;
const struct resource *initrd_res;
- fdt = bootm_get_devicetree(data);
- if (IS_ERR(fdt))
- return fdt;
- if (!fdt)
- goto out;
-
initrd_res = bootm_load_initrd(data, image_end);
if (IS_ERR(initrd_res)) {
return ERR_CAST(initrd_res);
@@ -82,6 +76,15 @@ void *booti_load_image(struct image_data *data, phys_addr_t *oftree)
devicetree = image_end;
+ fdt = bootm_get_devicetree(data);
+ if (IS_ERR(fdt))
+ return fdt;
+ if (!fdt) {
+ if (initrd_res)
+ pr_warn("initrd discarded due to missing devicetree.\n");
+ goto out;
+ }
+
ret = bootm_load_devicetree(data, fdt, devicetree);
free(fdt);
--
2.39.5
next reply other threads:[~2025-06-12 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 8:18 Ahmad Fatoum [this message]
2025-06-12 9:13 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612081809.4170727-1-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox