From: Bastian Krause <bst@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Bastian Krause <bst@pengutronix.de>
Subject: [PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully
Date: Tue, 17 Jun 2025 14:42:38 +0200 [thread overview]
Message-ID: <20250617124238.2024714-1-bst@pengutronix.de> (raw)
With CONFIG_INPUT=y, inputs are registered as consoles without setting
the dev member. This leads to a NULL pointer dereference when passed to
dev_of_node().
So add a check prior to calling dev_of_node() with a NULL pointer to
prevent this.
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
common/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/console.c b/common/console.c
index f94dbe3243c..424290b6cd1 100644
--- a/common/console.c
+++ b/common/console.c
@@ -264,7 +264,7 @@ struct console_device *of_console_by_stdout_path(void)
return NULL;
for_each_console(console) {
- if (dev_of_node(console->dev) == stdout_np)
+ if (console->dev && dev_of_node(console->dev) == stdout_np)
return console;
}
--
2.39.5
reply other threads:[~2025-06-17 13:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617124238.2024714-1-bst@pengutronix.de \
--to=bst@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox