* [PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully
@ 2025-06-17 12:42 Bastian Krause
0 siblings, 0 replies; only message in thread
From: Bastian Krause @ 2025-06-17 12:42 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum, Bastian Krause
With CONFIG_INPUT=y, inputs are registered as consoles without setting
the dev member. This leads to a NULL pointer dereference when passed to
dev_of_node().
So add a check prior to calling dev_of_node() with a NULL pointer to
prevent this.
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
common/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/console.c b/common/console.c
index f94dbe3243c..424290b6cd1 100644
--- a/common/console.c
+++ b/common/console.c
@@ -264,7 +264,7 @@ struct console_device *of_console_by_stdout_path(void)
return NULL;
for_each_console(console) {
- if (dev_of_node(console->dev) == stdout_np)
+ if (console->dev && dev_of_node(console->dev) == stdout_np)
return console;
}
--
2.39.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-06-17 13:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-17 12:42 [PATCH] console: handle input consoles in of_console_by_stdout_path() gracefully Bastian Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox