mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Bo Sun <bo@mboxify.com>
To: barebox@lists.infradead.org
Subject: [PATCH 2/3] miitool: clarify help text for default behavior and -s option
Date: Fri, 11 Jul 2025 20:27:28 +0800	[thread overview]
Message-ID: <20250711122729.108015-2-bo@mboxify.com> (raw)
In-Reply-To: <20250711122729.108015-1-bo@mboxify.com>

The -s option description was misleading about default behavior.
Clarify that miitool without options shows all PHYs, and -s requires
a device argument.

Signed-off-by: Bo Sun <bo@mboxify.com>
---
 commands/miitool.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/commands/miitool.c b/commands/miitool.c
index 0121fdc542..0c70b51ad3 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -344,9 +344,11 @@ BAREBOX_CMD_HELP_TEXT("Media Independent Interface (MII) unit as well as allowin
 BAREBOX_CMD_HELP_TEXT("register dummy PHY devices for raw MDIO access. Most fast ethernet")
 BAREBOX_CMD_HELP_TEXT("adapters use an MII to autonegotiate link speed and duplex setting.")
 BAREBOX_CMD_HELP_TEXT("")
+BAREBOX_CMD_HELP_TEXT("When run without options, shows status of all PHYs.")
+BAREBOX_CMD_HELP_TEXT("")
 BAREBOX_CMD_HELP_TEXT("Options:")
 BAREBOX_CMD_HELP_OPT("-v", "increase verbosity")
-BAREBOX_CMD_HELP_OPT("-s <devpath/devname>", "show PHY status (not providing PHY prints status of all)")
+BAREBOX_CMD_HELP_OPT("-s <devpath/devname>", "show PHY status for specified device")
 BAREBOX_CMD_HELP_OPT("-r <busno>:<adr>", "register a PHY")
 BAREBOX_CMD_HELP_END
 



  reply	other threads:[~2025-07-11 12:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 12:27 [PATCH 1/3] driver: clean up comment formatting and spacing Bo Sun
2025-07-11 12:27 ` Bo Sun [this message]
2025-07-11 12:53   ` [PATCH 2/3] miitool: clarify help text for default behavior and -s option Ahmad Fatoum
2025-07-11 12:27 ` [PATCH 3/3] of: base: fix of_match_node function documentation Bo Sun
2025-07-11 12:55   ` Ahmad Fatoum
2025-07-11 12:39 ` [PATCH 1/3] driver: clean up comment formatting and spacing Ahmad Fatoum
2025-07-11 13:43   ` Bo Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250711122729.108015-2-bo@mboxify.com \
    --to=bo@mboxify.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox