mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: [PATCH v2 13/15] nvmem: core: add cell based fixup logic
Date: Mon, 18 Aug 2025 19:44:47 +0200	[thread overview]
Message-ID: <20250818-v2025-06-0-topic-nvmem-v2-13-b6d677f6c519@pengutronix.de> (raw)
In-Reply-To: <20250818-v2025-06-0-topic-nvmem-v2-0-b6d677f6c519@pengutronix.de>

To further sync the nvmem code base port Linux commits:

| commit de12c9691501ccba41a154c223869f82be4c12fd
| Author: Michael Walle <michael@walle.cc>
| Date:   Tue Apr 4 18:21:25 2023 +0100
|
|     nvmem: core: allow to modify a cell before adding it
|
|     Provide a way to modify a cell before it will get added. This is useful
|     to attach a custom post processing hook via a layout.
|
|     Signed-off-by: Michael Walle <michael@walle.cc>
|     Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
|     Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
|     Link: https://lore.kernel.org/r/20230404172148.82422-18-srinivas.kandagatla@linaro.org
|     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

| commit 1172460e716784ac7e1049a537bdca8edbf97360
| Author: Miquel Raynal <miquel.raynal@bootlin.com>
| Date:   Fri Dec 15 11:15:31 2023 +0000
|
|     nvmem: Move and rename ->fixup_cell_info()
|
|     This hook is meant to be used by any provider and instantiating a layout
|     just for this is useless. Let's instead move this hook to the nvmem
|     device and add it to the config structure to be easily shared by the
|     providers.
|
|     While at moving this hook, rename it ->fixup_dt_cell_info() to clarify
|     its main intended purpose.
|
|     Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
|     Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
|     Link: https://lore.kernel.org/r/20231215111536.316972-6-srinivas.kandagatla@linaro.org
|     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

The next commit will get rid of the global nvmem->cell_post_process()
hook.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/nvmem/core.c           | 4 ++++
 drivers/nvmem/internals.h      | 2 ++
 include/linux/nvmem-provider.h | 4 ++++
 3 files changed, 10 insertions(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 3eb390975a52a9bbfc088d0abcd301a2cff9bf46..da3847f3b9f9bf8d122800bdd9073721770c2a05 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -373,6 +373,9 @@ static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_nod
 
 		info.np = of_node_get(child);
 
+		if (nvmem->fixup_dt_cell_info)
+			nvmem->fixup_dt_cell_info(nvmem, &info);
+
 		ret = nvmem_add_one_cell(nvmem, &info);
 		kfree(info.name);
 		if (ret) {
@@ -468,6 +471,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
 	nvmem->dev.of_node = np;
 	nvmem->priv = config->priv;
 	INIT_LIST_HEAD(&nvmem->cells);
+	nvmem->fixup_dt_cell_info = config->fixup_dt_cell_info;
 	nvmem->cell_post_process = config->cell_post_process;
 
 	rval = nvmem_add_cells_from_legacy_of(nvmem);
diff --git a/drivers/nvmem/internals.h b/drivers/nvmem/internals.h
index 58382be750ec0382c427e3b3bcd676a789a7395a..43f2e8c1d4ab04fbf713f9441f36d91174238a15 100644
--- a/drivers/nvmem/internals.h
+++ b/drivers/nvmem/internals.h
@@ -22,6 +22,8 @@ struct nvmem_device {
 	struct nvmem_layout	*layout;
 	struct list_head	cells;
 	nvmem_cell_post_process_t cell_post_process;
+	void (*fixup_dt_cell_info)(struct nvmem_device *nvmem,
+				   struct nvmem_cell_info *cell);
 	int			(*reg_write)(void *ctx, unsigned int reg,
 					     const void *val, size_t val_size);
 	int			(*reg_read)(void *ctx, unsigned int reg,
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 5b33d33d77e51683b3895095210562196e3b671d..18965fcdfec93110811c4479e0f622070b955f9a 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -58,6 +58,8 @@ struct nvmem_cell_info {
  * @dev:	Parent device.
  * @name:	Optional name.
  * @id:		Optional device ID used in full name. Ignored if name is NULL.
+ * @fixup_dt_cell_info: Will be called before a cell is added. Can be
+ *		used to modify the nvmem_cell_info.
  * @read_only:	Device is read-only.
  * @reg_read:	Callback to read data; return zero if successful.
  * @reg_write:	Callback to write data; return zero if successful.
@@ -70,6 +72,8 @@ struct nvmem_config {
 	struct device		*dev;
 	const char		*name;
 	int			id;
+	void (*fixup_dt_cell_info)(struct nvmem_device *nvmem,
+				   struct nvmem_cell_info *cell);
 	bool			read_only;
 	struct cdev		*cdev;
 	nvmem_reg_read_t	reg_read;

-- 
2.39.5




  parent reply	other threads:[~2025-08-18 18:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 17:44 [PATCH v2 00/15] NVMEM: Add support for layout drivers Marco Felsch
2025-08-18 17:44 ` [PATCH v2 01/15] of: sync of_*_phandle_with_args with Linux Marco Felsch
2025-08-18 17:44 ` [PATCH v2 02/15] of: base: add of_parse_phandle_with_optional_args() Marco Felsch
2025-08-18 17:44 ` [PATCH v2 03/15] of: device: Export of_device_make_bus_id() Marco Felsch
2025-08-18 17:44 ` [PATCH v2 04/15] nvmem: core: fix nvmem_register error path Marco Felsch
2025-08-18 17:44 ` [PATCH v2 05/15] nvmem: core: sync with Linux Marco Felsch
2025-08-20  7:32   ` Sascha Hauer
2025-08-20  9:09     ` Marco Felsch
2025-08-18 17:44 ` [PATCH v2 06/15] nvmem: core: expose nvmem cells as cdev Marco Felsch
2025-08-20  7:33   ` Sascha Hauer
2025-08-20  9:09     ` Marco Felsch
2025-08-18 17:44 ` [PATCH v2 07/15] nvmem: core: allow single and dynamic device ids Marco Felsch
2025-08-20  7:47   ` Sascha Hauer
2025-08-20  9:13     ` Marco Felsch
2025-08-18 17:44 ` [PATCH v2 08/15] eeprom: at24: fix device name handling Marco Felsch
2025-08-18 17:44 ` [PATCH v2 09/15] nvmem: core: create a header for internal sharing Marco Felsch
2025-08-18 17:44 ` [PATCH v2 10/15] nvmem: core: add nvmem-layout support Marco Felsch
2025-08-19 12:46   ` Sascha Hauer
2025-08-19 14:39     ` Marco Felsch
2025-08-20  7:41   ` Sascha Hauer
2025-08-20  9:11     ` Marco Felsch
2025-08-20  9:40       ` Sascha Hauer
2025-08-20  9:55         ` Marco Felsch
2025-08-18 17:44 ` [PATCH v2 11/15] nvmem: core: add an index parameter to the cell Marco Felsch
2025-08-18 17:44 ` [PATCH v2 12/15] nvmem: core: add per-cell post processing Marco Felsch
2025-08-18 17:44 ` Marco Felsch [this message]
2025-08-18 17:44 ` [PATCH v2 14/15] nvmem: core: provide own priv pointer in post process callback Marco Felsch
2025-08-18 17:44 ` [PATCH v2 15/15] nvmem: core: drop global cell_post_process Marco Felsch
2025-08-19  7:23 ` [PATCH v2 00/15] NVMEM: Add support for layout drivers Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818-v2025-06-0-topic-nvmem-v2-13-b6d677f6c519@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox