mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 3/4] ARM: rockchip: bootm: don't propagate error from register_image_handler
Date: Wed, 20 Aug 2025 12:16:59 +0200	[thread overview]
Message-ID: <20250820-rkimage-signed-v1-3-0ad3d1d1c952@pengutronix.de> (raw)
In-Reply-To: <20250820-rkimage-signed-v1-0-0ad3d1d1c952@pengutronix.de>

register_image_handler() always returns 0 and never fails.

Make this obvious by not propagating the return code from
register_image_handler() but always returning 0 in
rockchip_register_barebox_image_handler().

This is a preparation for adding more image handlers for Rockchip.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/mach-rockchip/bootm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/bootm.c b/arch/arm/mach-rockchip/bootm.c
index 6f4aa278087639cf2088c4e0f83929f7c2b59db9..097b0af7d8ba29a37e50dcb0f7d823c0456d1020 100644
--- a/arch/arm/mach-rockchip/bootm.c
+++ b/arch/arm/mach-rockchip/bootm.c
@@ -118,6 +118,8 @@ static int rockchip_register_barebox_image_handler(void)
 	if (rockchip_soc() < 0)
 		return 0;
 
-	return register_image_handler(&image_handler_rkns_barebox_image);
+	register_image_handler(&image_handler_rkns_barebox_image);
+
+	return 0;
 }
 late_initcall(rockchip_register_barebox_image_handler);

-- 
2.39.5




  parent reply	other threads:[~2025-08-20 12:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 10:16 [PATCH 0/4] ARM: rockchip: add support for signed images Michael Tretter
2025-08-20 10:16 ` [PATCH 1/4] filetype: detect Rockchip " Michael Tretter
2025-08-20 10:16 ` [PATCH 2/4] ARM: rockchip: bbu: accept " Michael Tretter
2025-08-20 10:16 ` Michael Tretter [this message]
2025-08-20 10:17 ` [PATCH 4/4] ARM: rockchip: bootm: " Michael Tretter
2025-08-20 12:30 ` [PATCH 0/4] ARM: rockchip: add support for " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250820-rkimage-signed-v1-3-0ad3d1d1c952@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox