mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: [PATCH v6 10/12] FIT: fit_open: canonicalize provided filename
Date: Wed, 20 Aug 2025 11:48:42 +0200	[thread overview]
Message-ID: <20250820-v2024-05-0-topic-fit-overlay-v6-10-9d1b3bab2ee2@pengutronix.de> (raw)
In-Reply-To: <20250820-v2024-05-0-topic-fit-overlay-v6-0-9d1b3bab2ee2@pengutronix.de>

Resolve any possible filename links to prepare the FIT code to cache the
fit_open() calls.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 common/image-fit.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/common/image-fit.c b/common/image-fit.c
index 0067f46e60bc954b418aef3398e2c10856b41c02..afd82637444a479c8cbb41c5d779da6a013c0386 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -972,12 +972,19 @@ struct fit_handle *fit_open_buf(const void *buf, size_t size, bool verbose,
  *
  * Return: A handle to a FIT image or a ERR_PTR
  */
-struct fit_handle *fit_open(const char *filename, bool verbose,
+struct fit_handle *fit_open(const char *_filename, bool verbose,
 			    enum bootm_verify verify, loff_t max_size)
 {
 	struct fit_handle *handle;
+	char *filename;
 	int ret;
 
+	filename = canonicalize_path(AT_FDCWD, _filename);
+	if (!filename) {
+		pr_err("Cannot open %s: %m\n", _filename);
+		return ERR_PTR(-errno);
+	}
+
 	handle = xzalloc(sizeof(struct fit_handle));
 
 	handle->verbose = verbose;
@@ -988,9 +995,12 @@ struct fit_handle *fit_open(const char *filename, bool verbose,
 	if (ret && ret != -EFBIG) {
 		pr_err("unable to read %s: %pe\n", filename, ERR_PTR(ret));
 		free(handle);
+		free(filename);
 		return ERR_PTR(ret);
 	}
 
+	free(filename);
+
 	handle->fit = handle->fit_alloc;
 
 	ret = fit_do_open(handle);

-- 
2.39.5




  parent reply	other threads:[~2025-08-20 10:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20  9:48 [PATCH v6 00/12] Add FIT image overlay support Marco Felsch
2025-08-20  9:48 ` [PATCH v6 01/12] FIT: fix missing free in fit_open error path Marco Felsch
2025-08-20  9:48 ` [PATCH v6 02/12] FIT: fit_open_configuration: add match function support Marco Felsch
2025-08-20  9:48 ` [PATCH v6 03/12] of: overlay: make the pattern match function more generic Marco Felsch
2025-08-20  9:48 ` [PATCH v6 04/12] of: overlay: make search dir " Marco Felsch
2025-08-20  9:48 ` [PATCH v6 05/12] of: overlay: refactor of_overlay_global_fixup Marco Felsch
2025-08-20  9:48 ` [PATCH v6 06/12] FIT: make fit_config_verify_signature public Marco Felsch
2025-08-20  9:48 ` [PATCH v6 07/12] of: overlay: add FIT image overlay support Marco Felsch
2025-08-20  9:48 ` [PATCH v6 08/12] of: overlay: replace filename with an more unique name Marco Felsch
2025-08-20  9:48 ` [PATCH v6 09/12] of: overlay: add more debugging prints to of_overlay_matches_filter Marco Felsch
2025-08-20  9:48 ` Marco Felsch [this message]
2025-08-20  9:48 ` [PATCH v6 11/12] FIT: fit_open: save the filename Marco Felsch
2025-08-20  9:48 ` [PATCH v6 12/12] FIT: add support to cache opened fit images Marco Felsch
2025-08-20 11:59   ` Ahmad Fatoum
2025-08-20 14:51     ` Marco Felsch
2025-08-20 20:41       ` Marco Felsch
2025-08-20 12:00   ` Sascha Hauer
2025-08-20 14:47     ` Marco Felsch
2025-08-20 11:54 ` [PATCH v6 00/12] Add FIT image overlay support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250820-v2024-05-0-topic-fit-overlay-v6-10-9d1b3bab2ee2@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox