From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: [PATCH v6 04/12] of: overlay: make search dir more generic
Date: Wed, 20 Aug 2025 11:48:36 +0200 [thread overview]
Message-ID: <20250820-v2024-05-0-topic-fit-overlay-v6-4-9d1b3bab2ee2@pengutronix.de> (raw)
In-Reply-To: <20250820-v2024-05-0-topic-fit-overlay-v6-0-9d1b3bab2ee2@pengutronix.de>
Rename global.of.overlay.dir to global.of.overlay.path to prepare the
codebase to handle FIT image overlays as well because *.path doesn't
imply that it have to be a directory.
Keep the backward compatibility by providing the of.overlay.dir variable
but mark it as deprecated.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Documentation/user/devicetree.rst | 2 +-
drivers/of/overlay.c | 15 ++++++++-------
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/Documentation/user/devicetree.rst b/Documentation/user/devicetree.rst
index ef04e14f7c0dde579493425073f1ee01395f0d8c..30a15a8865c154f8afe23d641da10d0afa84423b 100644
--- a/Documentation/user/devicetree.rst
+++ b/Documentation/user/devicetree.rst
@@ -108,7 +108,7 @@ Device tree overlays on the kernel device tree
Overlays can be applied to the kernel device tree before it is handed over to
the kernel. The behaviour is controlled by different variables:
-``global.of.overlay.dir``
+``global.of.overlay.path``
Overlays are read from this directory. barebox will try to apply all overlays
found here if not limited by one of the other variables below. When the path
given here is an absolute path it is used as is. A relative path is relative
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index a63cca1b47e74615d4453a27a55fb15d1f706fae..bc3fdff0cd277b3460981769c2b220adfced6e80 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -408,7 +408,7 @@ int of_register_overlay(struct device_node *overlay)
}
static char *of_overlay_pattern;
-static char *of_overlay_dir;
+static char *of_overlay_path;
static char *of_overlay_basedir;
/**
@@ -468,13 +468,13 @@ static int of_overlay_global_fixup(struct device_node *root, void *data)
char *dir;
int ret;
- if (*of_overlay_dir == '/')
- return of_overlay_apply_dir(root, of_overlay_dir, true);
+ if (*of_overlay_path == '/')
+ return of_overlay_apply_dir(root, of_overlay_path, true);
- if (*of_overlay_dir == '\0')
+ if (*of_overlay_path == '\0')
return 0;
- dir = concat_path_file(of_overlay_basedir, of_overlay_dir);
+ dir = concat_path_file(of_overlay_basedir, of_overlay_path);
ret = of_overlay_apply_dir(root, dir, true);
@@ -616,9 +616,10 @@ static int of_overlay_init(void)
globalvar_add_simple_string("of.overlay.compatible", &of_overlay_compatible);
globalvar_add_simple_string("of.overlay.pattern", &of_overlay_pattern);
globalvar_add_simple_string("of.overlay.filter", &of_overlay_filter);
- globalvar_add_simple_string("of.overlay.dir", &of_overlay_dir);
+ globalvar_add_simple_string("of.overlay.path", &of_overlay_path);
globalvar_alias_deprecated("of.overlay.filepattern", "of.overlay.pattern");
+ globalvar_alias_deprecated("of.overlay.dir", "of.overlay.path");
of_overlay_register_filter(&of_overlay_pattern_filter);
of_overlay_register_filter(&of_overlay_filepattern_filter);
@@ -632,5 +633,5 @@ device_initcall(of_overlay_init);
BAREBOX_MAGICVAR(global.of.overlay.compatible, "space separated list of compatibles an overlay must match");
BAREBOX_MAGICVAR(global.of.overlay.pattern, "space separated list of filepatterns an overlay must match");
-BAREBOX_MAGICVAR(global.of.overlay.dir, "Directory to look for dt overlays");
+BAREBOX_MAGICVAR(global.of.overlay.path, "Path to look for dt overlays");
BAREBOX_MAGICVAR(global.of.overlay.filter, "space separated list of filters");
--
2.39.5
next prev parent reply other threads:[~2025-08-20 10:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 9:48 [PATCH v6 00/12] Add FIT image overlay support Marco Felsch
2025-08-20 9:48 ` [PATCH v6 01/12] FIT: fix missing free in fit_open error path Marco Felsch
2025-08-20 9:48 ` [PATCH v6 02/12] FIT: fit_open_configuration: add match function support Marco Felsch
2025-08-20 9:48 ` [PATCH v6 03/12] of: overlay: make the pattern match function more generic Marco Felsch
2025-08-20 9:48 ` Marco Felsch [this message]
2025-08-20 9:48 ` [PATCH v6 05/12] of: overlay: refactor of_overlay_global_fixup Marco Felsch
2025-08-20 9:48 ` [PATCH v6 06/12] FIT: make fit_config_verify_signature public Marco Felsch
2025-08-20 9:48 ` [PATCH v6 07/12] of: overlay: add FIT image overlay support Marco Felsch
2025-08-20 9:48 ` [PATCH v6 08/12] of: overlay: replace filename with an more unique name Marco Felsch
2025-08-20 9:48 ` [PATCH v6 09/12] of: overlay: add more debugging prints to of_overlay_matches_filter Marco Felsch
2025-08-20 9:48 ` [PATCH v6 10/12] FIT: fit_open: canonicalize provided filename Marco Felsch
2025-08-20 9:48 ` [PATCH v6 11/12] FIT: fit_open: save the filename Marco Felsch
2025-08-20 9:48 ` [PATCH v6 12/12] FIT: add support to cache opened fit images Marco Felsch
2025-08-20 11:59 ` Ahmad Fatoum
2025-08-20 14:51 ` Marco Felsch
2025-08-20 20:41 ` Marco Felsch
2025-08-20 12:00 ` Sascha Hauer
2025-08-20 14:47 ` Marco Felsch
2025-08-20 11:54 ` [PATCH v6 00/12] Add FIT image overlay support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820-v2024-05-0-topic-fit-overlay-v6-4-9d1b3bab2ee2@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox