From: chalianis1@gmail.com
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org, Chali Anis <chalianis1@gmail.com>
Subject: [PATCH] common: bootm: only use initrd override if non-empty
Date: Tue, 26 Aug 2025 02:11:08 -0400 [thread overview]
Message-ID: <20250826061108.3372599-1-chalianis1@gmail.com> (raw)
From: Chali Anis <chalianis1@gmail.com>
OSTree integration in Yocto generates an empty initramfs
file and references it in the boot configuration (under
/boot/loader/ostree-1.conf) to suppress init= kernel arguments.
This caused Barebox to always prefer the override, even when
the initramfs was empty, preventing booting of FIT images
that already contain an embedded initramfs.
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
common/bootm.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/common/bootm.c b/common/bootm.c
index 3a2eb262b26a..f31ef546d92c 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -279,14 +279,18 @@ static int bootm_open_initrd_uimage(struct image_data *data)
const struct resource *
bootm_load_initrd(struct image_data *data, unsigned long load_address)
{
+ struct stat st;
enum filetype type;
int ret;
if (!IS_ENABLED(CONFIG_BOOTM_INITRD))
return NULL;
- if (bootm_get_override(&data->initrd_file, bootm_overrides.initrd_file))
- goto initrd_file;
+ if (bootm_get_override(&data->initrd_file,
+ bootm_overrides.initrd_file)) {
+ if (!stat(data->initrd_file, &st) && st.st_size > 0)
+ goto initrd_file;
+ }
if (data->initrd_res)
return data->initrd_res;
--
2.34.1
reply other threads:[~2025-08-26 6:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826061108.3372599-1-chalianis1@gmail.com \
--to=chalianis1@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox