mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Kurz <akurz@blala.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Cc: Alexander Kurz <akurz@blala.de>
Subject: [PATCH] ARM i.MX: fix iMX6SL detection
Date: Wed, 27 Aug 2025 15:14:35 +0000	[thread overview]
Message-ID: <20250827151435.16352-1-akurz@blala.de> (raw)

When booting iMX6SL SoC, a message "detected unknown i.MX6 revision 1.2"
has been reported. Fix thie detection for iMX6SL again.

fixes: 82239accfc8  ("ARM: i.MX6: factor out function to read si_rev")
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 include/mach/imx/imx6.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/mach/imx/imx6.h b/include/mach/imx/imx6.h
index f36ac6ce40..109df9b811 100644
--- a/include/mach/imx/imx6.h
+++ b/include/mach/imx/imx6.h
@@ -63,7 +63,7 @@ static inline uint32_t __imx6_read_si_rev(void)
 	si_rev = readl(MX6_ANATOP_BASE_ADDR + IMX6SL_ANATOP_SI_REV);
 	cpu_type = SI_REV_CPUTYPE(si_rev);
 
-	if (si_rev == 0x60)
+	if (cpu_type == (IMX6_CPUTYPE_IMX6SL & 0xff))
 		return si_rev;
 
 	return 0;
@@ -74,8 +74,8 @@ static inline int __imx6_cpu_type(void)
 	uint32_t si_rev = __imx6_read_si_rev();
 	uint32_t cpu_type = SI_REV_CPUTYPE(si_rev);
 
-	/* intentionally skip scu_get_core_count() for MX6SL */
-	if (cpu_type == IMX6_CPUTYPE_IMX6SL)
+	/* There exists only one, single-cored iMX6SL variant. */
+	if (cpu_type == (IMX6_CPUTYPE_IMX6SL & 0xff))
 		return IMX6_CPUTYPE_IMX6SL;
 
 	cpu_type |= scu_get_core_count() << 8;
-- 
2.39.5




                 reply	other threads:[~2025-08-27 17:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827151435.16352-1-akurz@blala.de \
    --to=akurz@blala.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox