From: chalianis1@gmail.com
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org, Chali Anis <chalianis1@gmail.com>
Subject: [PATCH] drivers: video: efi-gop: fix null reference pointer on priv->fb.mode=NULL.
Date: Thu, 28 Aug 2025 00:14:19 -0400 [thread overview]
Message-ID: <20250828041419.1874774-1-chalianis1@gmail.com> (raw)
From: Chali Anis <chalianis1@gmail.com>
fix a null reference pointer on mode variable, that was never initialized,
the mode will be set by the framebuffer subsyetem after initialisation so
it's not necessary to change the resolution here.
Fixes: 6518b21c6c66 ("video: add EFI Graphics Output Protocol support")
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
drivers/video/efi_gop.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/efi_gop.c b/drivers/video/efi_gop.c
index f4f58d9271f5..cef8a6816cac 100644
--- a/drivers/video/efi_gop.c
+++ b/drivers/video/efi_gop.c
@@ -169,8 +169,6 @@ static int efi_gop_query(struct efi_gop_priv *priv)
priv->fb.screen_base = mode->frame_buffer_base;
priv->mode = mode->mode;
- priv->fb.xres = priv->fb.mode->xres;
- priv->fb.yres = priv->fb.mode->yres;
return 0;
}
--
2.34.1
reply other threads:[~2025-08-28 4:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828041419.1874774-1-chalianis1@gmail.com \
--to=chalianis1@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox