mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] drivers: video: efi-gop: fix null reference pointer on priv->fb.mode=NULL.
@ 2025-08-28  4:14 chalianis1
  0 siblings, 0 replies; only message in thread
From: chalianis1 @ 2025-08-28  4:14 UTC (permalink / raw)
  To: s.hauer; +Cc: barebox, Chali Anis

From: Chali Anis <chalianis1@gmail.com>

fix a null reference pointer on mode variable, that was never initialized,
the mode will be set by the framebuffer subsyetem after initialisation so
it's not necessary to change the resolution here.

Fixes: 6518b21c6c66 ("video: add EFI Graphics Output Protocol support")

Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
 drivers/video/efi_gop.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/efi_gop.c b/drivers/video/efi_gop.c
index f4f58d9271f5..cef8a6816cac 100644
--- a/drivers/video/efi_gop.c
+++ b/drivers/video/efi_gop.c
@@ -169,8 +169,6 @@ static int efi_gop_query(struct efi_gop_priv *priv)
 
 	priv->fb.screen_base = mode->frame_buffer_base;
 	priv->mode = mode->mode;
-	priv->fb.xres = priv->fb.mode->xres;
-	priv->fb.yres = priv->fb.mode->yres;
 
 	return 0;
 }
-- 
2.34.1




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-28  4:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-28  4:14 [PATCH] drivers: video: efi-gop: fix null reference pointer on priv->fb.mode=NULL chalianis1

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox