* [PATCH 1/2] mci: am654-sdhci: Wait for transfer complete interrupt with MMC_RSP_BUSY cmd
@ 2025-08-28 11:34 Sascha Hauer
2025-08-28 11:34 ` [PATCH 2/2] mci: sdhci: am654: Use sdhci_wait_idle() Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2025-08-28 11:34 UTC (permalink / raw)
To: Barebox List
The MMC_RSP_BUSY flag indicates that we have to wait for the transfer
completion interrupt. Other SDHCI drivers do this, but the am654 driver
missed it.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/am654-sdhci.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mci/am654-sdhci.c b/drivers/mci/am654-sdhci.c
index 24abf10492..34a42be2aa 100644
--- a/drivers/mci/am654-sdhci.c
+++ b/drivers/mci/am654-sdhci.c
@@ -459,7 +459,7 @@ static int am654_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
struct mci_data *data)
{
struct am654_sdhci_plat *host = container_of(mci, struct am654_sdhci_plat, mci);
- u32 command, xfer;
+ u32 mask, command, xfer;
int ret;
dma_addr_t dma;
@@ -469,6 +469,10 @@ static int am654_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, ~0);
+ mask = SDHCI_INT_CMD_COMPLETE;
+ if (cmd->resp_type & MMC_RSP_BUSY)
+ mask |= SDHCI_INT_XFER_COMPLETE;
+
sdhci_write8(&host->sdhci, SDHCI_TIMEOUT_CONTROL, 0xe);
sdhci_setup_data_dma(&host->sdhci, data, &dma);
@@ -481,7 +485,7 @@ static int am654_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
sdhci_write32(&host->sdhci, SDHCI_ARGUMENT, cmd->cmdarg);
sdhci_write16(&host->sdhci, SDHCI_COMMAND, command);
- ret = sdhci_wait_for_done(&host->sdhci, SDHCI_INT_CMD_COMPLETE);
+ ret = sdhci_wait_for_done(&host->sdhci, mask);
if (ret) {
sdhci_teardown_data(&host->sdhci, data, dma);
goto error;
--
2.47.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] mci: sdhci: am654: Use sdhci_wait_idle()
2025-08-28 11:34 [PATCH 1/2] mci: am654-sdhci: Wait for transfer complete interrupt with MMC_RSP_BUSY cmd Sascha Hauer
@ 2025-08-28 11:34 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-08-28 11:34 UTC (permalink / raw)
To: Barebox List
sdhci_wait_idle() is what Linux does and it works fine in barebox.
sdhci_wait_idle_data() instead also waits for the SDHCI_CMD_INHIBIT_DATA
bit which shouldn't be necessary.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/am654-sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mci/am654-sdhci.c b/drivers/mci/am654-sdhci.c
index 34a42be2aa..0b79394c52 100644
--- a/drivers/mci/am654-sdhci.c
+++ b/drivers/mci/am654-sdhci.c
@@ -463,7 +463,7 @@ static int am654_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd,
int ret;
dma_addr_t dma;
- ret = sdhci_wait_idle_data(&host->sdhci, cmd);
+ ret = sdhci_wait_idle(&host->sdhci, cmd, data);
if (ret)
return ret;
--
2.47.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-28 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-28 11:34 [PATCH 1/2] mci: am654-sdhci: Wait for transfer complete interrupt with MMC_RSP_BUSY cmd Sascha Hauer
2025-08-28 11:34 ` [PATCH 2/2] mci: sdhci: am654: Use sdhci_wait_idle() Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox