mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] net: fec_imx: Fix probe failure on i.MX27
@ 2025-09-17 14:06 Sascha Hauer
  2025-09-18 14:25 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2025-09-17 14:06 UTC (permalink / raw)
  To: Barebox List

FEC_TYPE_IMX27 is 0 which meands device_get_match_data() returns NULL
and the driver bails out on the error check of this function. Start
counting the enum at one to pass the error check also on i.MX27.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/fec_imx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fec_imx.h b/drivers/net/fec_imx.h
index 1aaff87fdd..33b8db2745 100644
--- a/drivers/net/fec_imx.h
+++ b/drivers/net/fec_imx.h
@@ -114,7 +114,7 @@ struct buffer_descriptor {
 };
 
 enum fec_type {
-	FEC_TYPE_IMX27,
+	FEC_TYPE_IMX27 = 1,
 	FEC_TYPE_IMX28,
 	FEC_TYPE_IMX6,
 };
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: fec_imx: Fix probe failure on i.MX27
  2025-09-17 14:06 [PATCH] net: fec_imx: Fix probe failure on i.MX27 Sascha Hauer
@ 2025-09-18 14:25 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-09-18 14:25 UTC (permalink / raw)
  To: Barebox List, Sascha Hauer


On Wed, 17 Sep 2025 16:06:59 +0200, Sascha Hauer wrote:
> FEC_TYPE_IMX27 is 0 which meands device_get_match_data() returns NULL
> and the driver bails out on the error check of this function. Start
> counting the enum at one to pass the error check also on i.MX27.
> 
> 

Applied, thanks!

[1/1] net: fec_imx: Fix probe failure on i.MX27
      https://git.pengutronix.de/cgit/barebox/commit/?id=d37cbb49ccfa (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-18 14:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-17 14:06 [PATCH] net: fec_imx: Fix probe failure on i.MX27 Sascha Hauer
2025-09-18 14:25 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox