[PATCH] clk: rockchip: Drop empty init callback for rk3588 PLL type

[PATCH] clk: rockchip: Drop empty init callback for rk3588 PLL type

[Alexander Shiyan]

Unlike PLLs in previous geneation of SoCs, PLLs in RK3588 type don't
require any platform-specific initialization. Drop callback
rockchip_rk3588_pll_init() that does nothing in fact to clean the
driver up.
This change is taken from the mainline Linux kernel.

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 drivers/clk/rockchip/clk-pll.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
index 64f9e0dc5e..904d70d5d4 100644
--- a/drivers/clk/rockchip/clk-pll.c
+++ b/drivers/clk/rockchip/clk-pll.c
@@ -1021,16 +1021,6 @@ static int rockchip_rk3588_pll_is_enabled(struct clk_hw *hw)
 	return !(pllcon & RK3588_PLLCON1_PWRDOWN);
 }
 
-static int rockchip_rk3588_pll_init(struct clk_hw *hw)
-{
-	struct rockchip_clk_pll *pll = to_rockchip_clk_pll(hw);
-
-	if (!(pll->flags & ROCKCHIP_PLL_SYNC_RATE))
-		return 0;
-
-	return 0;
-}
-
 static const struct clk_ops rockchip_rk3588_pll_clk_norate_ops = {
 	.recalc_rate = rockchip_rk3588_pll_recalc_rate,
 	.enable = rockchip_rk3588_pll_enable,
@@ -1045,7 +1035,6 @@ static const struct clk_ops rockchip_rk3588_pll_clk_ops = {
 	.enable = rockchip_rk3588_pll_enable,
 	.disable = rockchip_rk3588_pll_disable,
 	.is_enabled = rockchip_rk3588_pll_is_enabled,
-	.init = rockchip_rk3588_pll_init,
 };
 
 /*
-- 
2.38.2

Re: [PATCH] clk: rockchip: Drop empty init callback for rk3588 PLL type

[Sascha Hauer]

On Wed, 24 Sep 2025 18:02:46 +0300, Alexander Shiyan wrote:
> Unlike PLLs in previous geneation of SoCs, PLLs in RK3588 type don't
> require any platform-specific initialization. Drop callback
> rockchip_rk3588_pll_init() that does nothing in fact to clean the
> driver up.
> This change is taken from the mainline Linux kernel.
> 
> 
> [...]

Applied, thanks!

[1/1] clk: rockchip: Drop empty init callback for rk3588 PLL type
      https://git.pengutronix.de/cgit/barebox/commit/?id=428b62495a2b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>