mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: chalianis1@gmail.com
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org, Chali Anis <chalianis1@gmail.com>
Subject: [PATCH] net: efi-snp: fix mac address change when it is not supported.
Date: Sat, 27 Sep 2025 12:33:01 -0400	[thread overview]
Message-ID: <20250927163301.1002593-1-chalianis1@gmail.com> (raw)

From: Chali Anis <chalianis1@gmail.com>

continue interface open if the efiret is unsupported since the mac address
change is not always supported, this permits to not fail when the network
could be used since it already has a network mac address configured, this 
is at least the case on qemu with certain versions of EDK2.

Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
 drivers/net/efi-snp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/efi-snp.c b/drivers/net/efi-snp.c
index 119358b6c880..b4d2abfecf77 100644
--- a/drivers/net/efi-snp.c
+++ b/drivers/net/efi-snp.c
@@ -219,7 +219,7 @@ static int efi_snp_eth_open(struct eth_device *edev)
 
 	efiret = priv->snp->station_address(priv->snp, false,
 			(struct efi_mac_address *)priv->snp->Mode->PermanentAddress.Addr );
-	if (EFI_ERROR(efiret)) {
+	if (EFI_ERROR(efiret) && efiret != EFI_UNSUPPORTED) {
 		dev_err(priv->dev, "failed to set MAC address: %s\n",
 				efi_strerror(efiret));
 		return -efi_errno(efiret);
-- 
2.34.1




             reply	other threads:[~2025-09-27 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-27 16:33 chalianis1 [this message]
2025-09-29 13:51 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250927163301.1002593-1-chalianis1@gmail.com \
    --to=chalianis1@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox