From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 29 Sep 2025 10:05:18 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v38so-002LcH-0S for lore@lore.pengutronix.de; Mon, 29 Sep 2025 10:05:18 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v38sn-0000kt-8j for lore@pengutronix.de; Mon, 29 Sep 2025 10:05:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d27L2CQtBGASRk0RYVVLzCQPq4BBZ4Ggc7evsqrIjhs=; b=xutwMnYmZrxHrnX5/LCuDTHG5t GsB+nRxOzhQ8l5AE3C8paEb5wajt7ydKv6IM6wQ2AjVCxGrdYtAg2odZVa0DK3f6qAEDW7LevJd0Y K7Vy7ggxtDoxJHqfMehJc1bfPx2oNaxAOuFPuMLgJBZD1JHfQ8CVNkSmnbltQdHmga/idNQG+Eb/v yHuIB4v/x9e+1vzFow9FtXp1SsFJ/8t9kPINfxaa6OdUK3bXSCYfpgduW7EktQ1s4+TrU4s29hEe+ gouJtDzQMBbl+yev8krjDwtANrpQpMjVeIsRz2cBREbfLTTWz/jI6A2DswB/aCSDDeQfCfwgY9hUb wqCBHKQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v38sG-00000001iOs-0mDN; Mon, 29 Sep 2025 08:04:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v38s9-00000001iGt-19oS for barebox@lists.infradead.org; Mon, 29 Sep 2025 08:04:40 +0000 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1v38s6-000070-D8; Mon, 29 Sep 2025 10:04:34 +0200 From: Jonas Rebmann Date: Mon, 29 Sep 2025 10:03:57 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250929-tlv-integration-v2-6-55f75da7e670@pengutronix.de> References: <20250929-tlv-integration-v2-0-55f75da7e670@pengutronix.de> In-Reply-To: <20250929-tlv-integration-v2-0-55f75da7e670@pengutronix.de> To: Sascha Hauer , BAREBOX Cc: Tobias Waldekranz , Jonas Rebmann X-Mailer: b4 0.15-dev-7abec X-Developer-Signature: v=1; a=openpgp-sha256; l=1005; i=jre@pengutronix.de; h=from:subject:message-id; bh=iFeo3AtjuwFu9w/cIpOk18QbDXu8BwuBHPlD+w9G2y4=; b=owGbwMvMwCV2ZcYT3onnbjcwnlZLYsi4ZTth96RJ91JfGjzdOXG96G/H6J8xRrdnrr646ZGyu VDwh7vOHR2lLAxiXAyyYoossWpyCkLG/tfNKu1iYeawMoEMYeDiFICJWNUx/NOV+X/1eOpR7ri7 T+b/S2ZhmfJL3t8iZvLfmBNcE3Nf+voz/I9Wfe5pp//F9bBrjuXqvenJbw/cCFjecEhH8YnWMpn fj9gA X-Developer-Key: i=jre@pengutronix.de; a=openpgp; fpr=0B7B750D5D3CD21B3B130DE8B61515E135CD49B5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250929_010437_370397_9F8784A1 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 6/9] commands: tlv: clarify error opening tlv X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Returning PTR_ERR(tlvdev) instead of printing an error message leads to the same output when CONFIG_CMD_TLV and when the specified path could not be read: tlv: No such file or directory In the latter case, print an explanatory message instead. Signed-off-by: Jonas Rebmann --- commands/tlv.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/commands/tlv.c b/commands/tlv.c index 53fbc2a291..6118a2947f 100644 --- a/commands/tlv.c +++ b/commands/tlv.c @@ -28,9 +28,11 @@ static int do_tlv(int argc, char *argv[]) if (!filename) return COMMAND_ERROR_USAGE; - tlvdev = tlv_register_device_by_path(argv[optind], NULL); - if (IS_ERR(tlvdev)) - return PTR_ERR(tlvdev); + tlvdev = tlv_register_device_by_path(filename, NULL); + if (IS_ERR(tlvdev)) { + printf("Could not open \"%s\": %m\n", filename); + return COMMAND_ERROR; + } if (fixup) return tlv_of_register_fixup(tlvdev); -- 2.51.0.297.gca2559c1d6