From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: sha@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after
Date: Tue, 30 Sep 2025 10:53:58 +0200 [thread overview]
Message-ID: <20250930085401.2133061-1-a.fatoum@pengutronix.de> (raw)
The current logic inside MAKEALL is flawed: We source an ARM64 config
with CROSS_COMPILE=${CROSS_COMPILE_arm} and hope that CONFIG_ARM64
results, so we can grep for it in the .config despite it missing in the
defconfig.
Replace this by looking for CONFIG_64BIT instead in the defconfig
directly. This symbol seems to be there for all ARM64 configs we have
and if this ceases, CI will let us know.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
MAKEALL | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/MAKEALL b/MAKEALL
index d47f0204f1f1..abce297a9bf8 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -135,13 +135,10 @@ do_build_defconfig() {
[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
- ${MAKE} ${defconfig} &>/dev/null
- if [ ${arch} = "arm" ]; then
- grep -q "CONFIG_ARM64=y" ${BUILDDIR}/.config
- if [ $? = 0 ]; then
- arch=arm64
- fi
+ grep -q "CONFIG_64BIT=y" arch/${arch}/configs/${defconfig}
+ if [ $? = 0 ]; then
+ arch=arm64
fi
tmp=$(echo "${defconfig}" | tr - _)
--
2.47.3
next reply other threads:[~2025-09-30 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 8:53 Ahmad Fatoum [this message]
2025-09-30 9:54 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930085401.2133061-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox