mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: sha@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] Revert "MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after"
Date: Tue, 30 Sep 2025 12:38:22 +0200	[thread overview]
Message-ID: <20250930103822.2395670-1-a.fatoum@pengutronix.de> (raw)

The commit being reverted here assumed that all defconfigs have a
corresponding file, but this doesn't hold true for generated configs
like multi_v8_efi_defconfig.

The issue that was meant to be addressed disappeared after rerunning
the test, so it might have been just a fluke (or triggered by shuffle,
although I was unable to reproduce with the same seed).

Until better understood, reinstate the old code.

Fixes: bdf0a4da1d28 ("MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 MAKEALL | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index abce297a9bf8..d47f0204f1f1 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -135,10 +135,13 @@ do_build_defconfig() {
 	[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
 
 	MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
+	${MAKE} ${defconfig} &>/dev/null
 
-	grep -q "CONFIG_64BIT=y" arch/${arch}/configs/${defconfig}
-	if [ $? = 0 ]; then
-		arch=arm64
+	if [ ${arch} = "arm" ]; then
+		grep -q "CONFIG_ARM64=y" ${BUILDDIR}/.config
+		if [ $? = 0 ]; then
+			arch=arm64
+		fi
 	fi
 
 	tmp=$(echo "${defconfig}" | tr - _)
-- 
2.47.3




             reply	other threads:[~2025-09-30 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30 10:38 Ahmad Fatoum [this message]
2025-09-30 10:40 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250930103822.2395670-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox