From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Oct 2025 07:53:02 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v763q-006Ckg-2f for lore@lore.pengutronix.de; Fri, 10 Oct 2025 07:53:02 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v763q-0003TH-9s for lore@pengutronix.de; Fri, 10 Oct 2025 07:53:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Z6xFTcJ+cc23rB9aHBmtyNUdhsZdLoX4+k/xLD9COLg=; b=IBpK4proJyDgyoksh9Q+MGo9hJ tdPtn0hNiFXb2SeVsrR6hsf/NWY1DV9Ak4MTRrQHMtcO8byWli5hCELPEtmlhxwZMWG643kwTpHx9 C4Tfk9bqE/mbEt7J7zodK+VQp5FPzKmu+IitQVv6jyyADlYh8e9bfriA3KytDALb3KFpNNR9Ai92i 7B+lER525jq3d1ZWnsMC6kfL+kPzG9K85Z2v6QYU52gqKH4CHCjfHgD2BT7QM4H/ptBVzZArEraEN dExVHavrYDRDF4ggGdKZDJg/HLBbvxxztgfNnCTm+HoFVAh2c2bJnm5KTBKzhDiHVmmYYmySfLHPD uUqVV5zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v763R-00000007jSv-3CHj; Fri, 10 Oct 2025 05:52:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v763P-00000007jSI-2Fzh for barebox@lists.infradead.org; Fri, 10 Oct 2025 05:52:36 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=geraet.lan) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1v763N-0003Mm-Rb; Fri, 10 Oct 2025 07:52:33 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 10 Oct 2025 07:52:28 +0200 Message-ID: <20251010055230.3069354-1-a.fatoum@barebox.org> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251009_225235_599444_09CA215E X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 1/2] scripts: sconfigpast: print panic message when nonnull fails X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Instead of just exiting with an error code of 2, print out to stderr, when we abort due to an unexpected NULL pointer. This helped tracked down a missing dependency in CI. Signed-off-by: Ahmad Fatoum --- scripts/basic/sconfigpost.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/basic/sconfigpost.c b/scripts/basic/sconfigpost.c index ddc0528773ff..38f5888865b6 100644 --- a/scripts/basic/sconfigpost.c +++ b/scripts/basic/sconfigpost.c @@ -49,13 +49,15 @@ static inline size_t str_has_prefix(const char *str, const char *prefix) return strncmp(str, prefix, len) == 0 ? len : 0; } -static void *nonnull(void *ptr) +static void *pnonnull(void *ptr, const char *ptrname) { if (!ptr) - exit(2); + panic("%s is unexpectedly NULL\n", ptrname); return ptr; } +#define nonnull(ptr) pnonnull(ptr, #ptr) + static FILE *xfopen(const char *path, const char *mode) { FILE *fp; @@ -367,6 +369,8 @@ static void append_dependency(FILE *depfile, const char *path) return; } + debug("appending dependency for %s\n", path); + abspath = nonnull(realpath(path, NULL)); fprintf(depfile, "\t%s \\\n", abspath); -- 2.47.3