From: Jonas Rebmann <jre@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Jonas Rebmann <jre@pengutronix.de>
Subject: [PATCH v2 11/17] common: tlv: default decoder for signed TLV
Date: Tue, 28 Oct 2025 19:03:16 +0100 [thread overview]
Message-ID: <20251028-tlv-signature-v2-11-3bafce636ad7@pengutronix.de> (raw)
In-Reply-To: <20251028-tlv-signature-v2-0-3bafce636ad7@pengutronix.de>
Introduce a second default decoder that behaves just like barebox_tlv_v1
but uses the "tlv-generic" keyring.
Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
.../devicetree/bindings/nvmem/barebox,tlv.yaml | 1 +
common/tlv/barebox.c | 25 +++++++++++++++++++++-
include/tlv/format.h | 1 +
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/nvmem/barebox,tlv.yaml b/Documentation/devicetree/bindings/nvmem/barebox,tlv.yaml
index 7a77b9a0b4..7d678ee04a 100644
--- a/Documentation/devicetree/bindings/nvmem/barebox,tlv.yaml
+++ b/Documentation/devicetree/bindings/nvmem/barebox,tlv.yaml
@@ -22,6 +22,7 @@ properties:
items:
- enum:
- barebox,tlv-v1 # magic: 0x61bb95f2
+ - barebox,tlv-v1-signed # magic: 0x61bb95f3
- lxa,tlv-baseboard-v1 # magic: 0xbc288dfe
- lxa,tlv-powerboard-v1 # magic: 0xdca5a870
- const: barebox,tlv
diff --git a/common/tlv/barebox.c b/common/tlv/barebox.c
index b941463b31..24de3eeaaa 100644
--- a/common/tlv/barebox.c
+++ b/common/tlv/barebox.c
@@ -177,16 +177,39 @@ static struct of_device_id of_matches[] = {
{ .compatible = "barebox,tlv-v1" },
{ /* sentinel */}
};
+static struct of_device_id of_matches_signed[] = {
+ { .compatible = "barebox,tlv-v1-signed" },
+ { /* sentinel */ }
+};
static struct tlv_decoder barebox_tlv_v1 = {
.magic = TLV_MAGIC_BAREBOX_V1,
.driver.name = "barebox-tlv-v1",
.driver.of_compatible = of_matches,
.mappings = mappings,
+ .signature_keyring = NULL,
+};
+
+static struct tlv_decoder barebox_tlv_v1_signed = {
+ .magic = TLV_MAGIC_BAREBOX_V1_SIGNED,
+ .driver.name = "barebox-tlv-v1-signed",
+ .driver.of_compatible = of_matches_signed,
+ .mappings = mappings,
+ .signature_keyring = "tlv-generic",
};
static int tlv_register_default(void)
{
- return tlv_register_decoder(&barebox_tlv_v1);
+ int err;
+
+ err = tlv_register_decoder(&barebox_tlv_v1);
+ if (err)
+ return err;
+ if (IS_ENABLED(CONFIG_TLV_SIGNATURE)) {
+ err = tlv_register_decoder(&barebox_tlv_v1_signed);
+ if (err)
+ return err;
+ }
+ return 0;
}
device_initcall(tlv_register_default);
diff --git a/include/tlv/format.h b/include/tlv/format.h
index cbe0a132b1..ab12f0c9bb 100644
--- a/include/tlv/format.h
+++ b/include/tlv/format.h
@@ -23,6 +23,7 @@
#include <linux/build_bug.h>
#define TLV_MAGIC_BAREBOX_V1 0x61bb95f2
+#define TLV_MAGIC_BAREBOX_V1_SIGNED 0x61bb95f3
#define TLV_MAGIC_LXA_BASEBOARD_V1 0xbc288dfe
#define TLV_MAGIC_LXA_POWERBOARD_V1 0xc6895c21
#define TLV_MAGIC_LXA_IOBOARD_V1 0xdca5a870
--
2.51.2.535.g419c72cb8a
next prev parent reply other threads:[~2025-10-28 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 18:03 [PATCH v2 00/17] TLV-Signature and keyrings Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 01/17] lib: idr: avoid dangling else in idr_for_each_entry() Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 02/17] common: clean up TLV code Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 03/17] crypto: Add support for keyrings Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 04/17] fit: only accept keys from "fit"-keyring Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 05/17] crypto: keytoc: Rename "hint" to "fit-hint" and do not use it in identifiers Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 06/17] commands: keys: update output format to include keyring Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 07/17] commands: tlv: Error out on invalid TLVs Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 08/17] scripts: bareboxtlv-generator: Implement signature Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 09/17] scripts: bareboxtlv-generator: Increase max_size in example schema Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 10/17] common: tlv: Add TLV-Signature support Jonas Rebmann
2025-10-28 18:03 ` Jonas Rebmann [this message]
2025-10-28 18:03 ` [PATCH v2 12/17] crypto: Use "development" keys for "fit" and "tlv" keyring Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 13/17] test: py: add signature to TLV integration tests Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 14/17] ci: pytest: Add kconfig fragment for TLV signature " Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 15/17] crypto: concatenate fit development certificate with private key Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 16/17] doc/barebox-tlv: Update documentation regarding TLV-Signature Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 17/17] Documentation: migration-2025.11.0: List changes to CONFIG_CRYPTO_PUBLIC_KEYS Jonas Rebmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028-tlv-signature-v2-11-3bafce636ad7@pengutronix.de \
--to=jre@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox