[PATCH] commands: usbgadget: improve error message on failure

[PATCH] commands: usbgadget: improve error message on failure

[Ahmad Fatoum]

The command reports EINVAL when encountering an option it doesn't
understand and the help text for other errors.

It's more useful to users to flip them around, so they can see e.g.
-EPERM if a security policy prevented the command from working.

Reported-by: Fabian Pflug <f.pflug@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 commands/usbgadget.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/commands/usbgadget.c b/commands/usbgadget.c
index 1cd8c915b1b1..2edccca1f36c 100644
--- a/commands/usbgadget.c
+++ b/commands/usbgadget.c
@@ -20,7 +20,6 @@ static int do_usbgadget(int argc, char *argv[])
 {
 	struct usbgadget_funcs funcs = {};
 	int opt;
-	int ret;
 
 	while ((opt = getopt(argc, argv, "asdA::D::S::b")) > 0) {
 		switch (opt) {
@@ -47,12 +46,11 @@ static int do_usbgadget(int argc, char *argv[])
 			usb_multi_unregister();
 			return 0;
 		default:
-			return -EINVAL;
+			return COMMAND_ERROR_USAGE;
 		}
 	}
 
-	ret = usbgadget_prepare_register(&funcs);
-	return ret ? COMMAND_ERROR_USAGE : 0;
+	return usbgadget_prepare_register(&funcs);
 }
 
 BAREBOX_CMD_HELP_START(usbgadget)
-- 
2.47.3

Re: [PATCH] commands: usbgadget: improve error message on failure

[Sascha Hauer]

On Wed, 05 Nov 2025 10:36:38 +0100, Ahmad Fatoum wrote:
> The command reports EINVAL when encountering an option it doesn't
> understand and the help text for other errors.
> 
> It's more useful to users to flip them around, so they can see e.g.
> -EPERM if a security policy prevented the command from working.
> 
> 
> [...]

Applied, thanks!

[1/1] commands: usbgadget: improve error message on failure
      https://git.pengutronix.de/cgit/barebox/commit/?id=84288a3726a8 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>