From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 5/5] efi: payload: align kernel boot status messages
Date: Fri, 7 Nov 2025 15:17:22 +0100 [thread overview]
Message-ID: <20251107141725.2590394-5-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20251107141725.2590394-1-a.fatoum@pengutronix.de>
To make debugging easier, let's explicitly call out if StartImage or
handover is used and on stdout as we do for other architectures.
While at it, we also skip printing the options if they are <NULL>.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
efi/payload/handover.c | 5 +++--
efi/payload/image.c | 6 ++++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/efi/payload/handover.c b/efi/payload/handover.c
index 12fd6d95c2e8..f549568b6d03 100644
--- a/efi/payload/handover.c
+++ b/efi/payload/handover.c
@@ -103,13 +103,14 @@ static int do_bootm_efi(struct image_data *data)
boot_header->code32_start = efi_virt_to_phys(loaded_image->image_base +
(image_header->setup_sects+1) * 512);
+ printf("Booting kernel via handover");
if (bootm_verbose(data)) {
- printf("\nStarting kernel at 0x%p", loaded_image->image_base);
+ printf("at 0x%p", loaded_image->image_base);
if (data->initrd_file)
printf(", initrd at 0x%08x",
boot_header->ramdisk_image);
- printf("...\n");
}
+ printf("...\n");
if (data->dryrun) {
BS->unload_image(handle);
diff --git a/efi/payload/image.c b/efi/payload/image.c
index ea6033edc363..22ff5d27ced6 100644
--- a/efi/payload/image.c
+++ b/efi/payload/image.c
@@ -119,14 +119,16 @@ int efi_execute_image(efi_handle_t handle,
(loaded_image->image_code_type == EFI_RUNTIME_SERVICES_CODE);
if (is_linux_image(filetype, loaded_image->image_base)) {
- pr_debug("Linux kernel detected. Adding bootargs.");
options = linux_bootargs_get();
- pr_info("add linux options '%s'\n", options);
+ printf("Booting kernel via StartImage");
if (options) {
+ printf("with options '%s'", options);
loaded_image->load_options = xstrdup_char_to_wchar(options);
loaded_image->load_options_size =
(strlen(options) + 1) * sizeof(wchar_t);
}
+ printf("...\n");
+
shutdown_barebox();
}
--
2.47.3
next prev parent reply other threads:[~2025-11-07 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 14:17 [PATCH master 1/5] efi: payload: drop unreferenced efi_do_execute_image() Ahmad Fatoum
2025-11-07 14:17 ` [PATCH master 2/5] filetype: introduce separate filetype_x86_efi_linux_image Ahmad Fatoum
2025-11-07 14:17 ` [PATCH master 3/5] efi: payload: handover: fix filetype match Ahmad Fatoum
2025-11-07 14:17 ` [PATCH master 4/5] efi: payload: reinstate error message when booting non-EFI stubbed kernel Ahmad Fatoum
2025-11-07 14:17 ` Ahmad Fatoum [this message]
2025-11-10 8:20 ` [PATCH master 1/5] efi: payload: drop unreferenced efi_do_execute_image() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107141725.2590394-5-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox