From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] dm: fix memory leak
Date: Mon, 10 Nov 2025 09:17:49 +0100 [thread overview]
Message-ID: <20251110081749.988471-1-s.hauer@pengutronix.de> (raw)
a dm_target is allocated in dm_parse_table(), thus must be freed in
dm_destroy(). The destroy op only frees everything related to the
dm_target, but not the dm_target itself.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/block/dm/dm-core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/block/dm/dm-core.c b/drivers/block/dm/dm-core.c
index 1bc3446cb0..fd7ed0d84e 100644
--- a/drivers/block/dm/dm-core.c
+++ b/drivers/block/dm/dm-core.c
@@ -428,6 +428,7 @@ static int dm_parse_table(struct dm_device *dm, const char *ctable)
list_for_each_entry_safe_reverse(ti, tmp, &dm->targets, list) {
ti->ops->destroy(ti);
list_del(&ti->list);
+ free(ti);
}
free(rowv);
@@ -439,12 +440,13 @@ static int dm_parse_table(struct dm_device *dm, const char *ctable)
void dm_destroy(struct dm_device *dm)
{
- struct dm_target *ti;
+ struct dm_target *ti, *tmp;
blockdevice_unregister(&dm->blk);
- list_for_each_entry_reverse(ti, &dm->targets, list) {
+ list_for_each_entry_safe_reverse(ti, tmp, &dm->targets, list) {
ti->ops->destroy(ti);
+ free(ti);
}
unregister_device(&dm->dev);
--
2.47.3
reply other threads:[~2025-11-10 8:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110081749.988471-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox