From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 12 Nov 2025 17:44:45 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJDxd-000Etv-29 for lore@lore.pengutronix.de; Wed, 12 Nov 2025 17:44:45 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vJDxd-000532-0A for lore@pengutronix.de; Wed, 12 Nov 2025 17:44:45 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=KGV8/cbxA391w6i5xxdgqeOKdQeEpKpfTgZoUH4zPwc=; b=16hmZdMy/1dbD/v3CwdOssX+dB QAc71nfda/xGCdqcfFE2hcvEhl/4BvpCspn+Ksl7RbYhWRS5oVDL5asGLxjoDNv7dhYNRsjj6z9Hc XjvwxRkNMzPKD6w/ZEF/lXlUPh/3w8AX+DFZaIbT7MNRgbrYaMXHMljERfHTQS9ZeJ4MqP0l/l9vY 5+nhlwAcHYZ5HKH+nY6Wea8Px+WETChIIh1PhRAH3/A6GofFgdgVkwOH8SowzV1IA/tgADWS9jPR0 Fxc0Du0MaVSRReZlEerLTzLmN8cmXl3ZBBVYENfnxxxw6vklrZVnyNPE+R6OOjWY980SGs1hXMTN1 GynX2XbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJDxC-00000009CSG-18aI; Wed, 12 Nov 2025 16:44:18 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJDx9-00000009CRr-3Big for barebox@lists.infradead.org; Wed, 12 Nov 2025 16:44:16 +0000 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vJDx8-0004w8-AI; Wed, 12 Nov 2025 17:44:14 +0100 From: Jonas Rebmann Date: Wed, 12 Nov 2025 17:43:51 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251112-tlv_bind_serial-v1-1-638cf222553a@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAEa5FGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDQ0Mj3ZKcsvikzLyUeJDGxBzdJIskI5NEs7QUk0QDJaCugqLUtMwKsIn RsbW1AMhnvXRhAAAA X-Change-ID: 20251112-tlv_bind_serial-b8b24a6fd4a0 To: Sascha Hauer , BAREBOX Cc: Jonas Rebmann X-Mailer: b4 0.15-dev-7abec X-Developer-Signature: v=1; a=openpgp-sha256; l=3966; i=jre@pengutronix.de; h=from:subject:message-id; bh=wYBrC0VcjHqYfcXWQPl9hED6SKQJnbRVKHUm4cFwgXI=; b=owGbwMvMwCV2ZcYT3onnbjcwnlZLYsgU2RlraMA7y8l1adzMVRdrSxvcHNg2LoqZ/8taK/+J+ uJWcRnnjhIWBjEuBlkxRZZYNTkFIWP/62aVdrEwc1iZQIYwcHEKwEQCbzL8WMoSqpFxptHtsjj7 t8iFWedsNMo4V5qlLW+6L+JXo1rA8N+zOWf2Cs86Nu127zsbHP9VpH9g/M+Rft2PJ+pO1rP98zg B X-Developer-Key: i=jre@pengutronix.de; a=openpgp; fpr=0B7B750D5D3CD21B3B130DE8B61515E135CD49B5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_084415_816241_6E741DCD X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] tlv: Add tlv_bind_serial mapping X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Particularly when using secure boot with signed TLVs, it may be required to issue and sign TLVs for specific units. As typically all units of a board are compiled to validate TLVs against the same key, a "binding" mechanism is needed if interchange of TLVs across those units must be prevented. This mapping binds against the SoC serial number (a.k.a. SoC UID) of the unit, rendering a signed TLV with such a field invalid for all but one unit. When generating TLVs that use this mapping, the exact case-sensitive string representation of the serial_number must be taken into account: All existing soc drivers supply the serial_number as uppercase hexadecimal representation without a prefix. Add the special mapping tlv_bind_serial that aborts TLV parsing if the supplied string does not match the SoC serial number. Include this mapping in barebox_tlv_v1_mappings with tag 0x0024 to make it available in testing and in other setups using the generic tlv parsers. These parsers will store the serial_number in the "bound-serial-number" field. Signed-off-by: Jonas Rebmann --- common/tlv/barebox.c | 32 ++++++++++++++++++++++++++++++++ include/tlv/tlv.h | 1 + 2 files changed, 33 insertions(+) diff --git a/common/tlv/barebox.c b/common/tlv/barebox.c index 24de3eeaaa..cba9c3e2da 100644 --- a/common/tlv/barebox.c +++ b/common/tlv/barebox.c @@ -3,6 +3,10 @@ #include #include #include +#include +#include +#include + int tlv_handle_serial(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val) { @@ -16,6 +20,32 @@ int tlv_handle_serial(struct tlv_device *dev, struct tlv_mapping *map, u16 len, return 0; } +int tlv_bind_serial(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val) +{ + struct bus_type *bus; + struct device_d *socdev; + const char *soc_serial; + char *tlv_serial = basprintf("%.*s", len, val); + + bus = get_bus_by_name("soc"); + if (!bus) { + pr_err("No 'soc' bus found\n"); + return -EACCES; + } + + for_each_device(socdev) { + soc_serial = dev_get_param(socdev, "serial_number"); + if (!soc_serial) + continue; + + if (streq_ptr(tlv_serial, soc_serial)) + return __tlv_format_str(dev, map, len, val) ? 0 : -ENOMEM; + + } + + return -EACCES; +} + int tlv_handle_eth_address(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val) { int i; @@ -169,6 +199,8 @@ struct tlv_mapping barebox_tlv_v1_mappings[] = { { 0x0011, tlv_handle_eth_address, "ethernet-address" }, /* A sequence of multiple Ethernet addresses */ { 0x0012, tlv_handle_eth_address_seq, "ethernet-address" }, + /* Reject TLVs if device serial number string does not match CPU serial */ + { 0x0024, tlv_bind_serial, "bound-serial-number"}, { /* sentintel */ }, }; diff --git a/include/tlv/tlv.h b/include/tlv/tlv.h index 536f61646c..cadade27b4 100644 --- a/include/tlv/tlv.h +++ b/include/tlv/tlv.h @@ -37,6 +37,7 @@ extern int tlv_format_hex(struct tlv_device *dev, struct tlv_mapping *map, u16 l extern int tlv_format_mac(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); extern int tlv_format_blob(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); extern int tlv_handle_serial(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); +extern int tlv_bind_serial(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); extern int tlv_handle_eth_address(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); extern int tlv_handle_eth_address_seq(struct tlv_device *dev, struct tlv_mapping *map, u16 len, const u8 *val); --- base-commit: f485ddfccf960959d25462073528d314b8bf1aea change-id: 20251112-tlv_bind_serial-b8b24a6fd4a0 Best regards, -- Jonas Rebmann