From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] bootargs: fix memory leak
Date: Thu, 27 Nov 2025 09:07:05 +0100 [thread overview]
Message-ID: <20251127080706.2736258-1-s.hauer@pengutronix.de> (raw)
globalvar_get_match() returns an allocated string. Free it after usage,
even when the allocated string is empty.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/bootargs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/bootargs.c b/common/bootargs.c
index ad8007d32a..36528b8b58 100644
--- a/common/bootargs.c
+++ b/common/bootargs.c
@@ -34,8 +34,10 @@ const char *linux_bootargs_get(void)
free(linux_bootargs);
bootargs = globalvar_get_match("linux.bootargs.", " ");
- if (!strlen(bootargs))
+ if (!strlen(bootargs)) {
+ free(bootargs);
return getenv("bootargs");
+ }
linux_bootargs = bootargs;
--
2.47.3
next reply other threads:[~2025-11-27 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 8:07 Sascha Hauer [this message]
2025-11-28 7:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127080706.2736258-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox