From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/3] driver: call free_device_res() from unregister_device()
Date: Thu, 27 Nov 2025 12:34:15 +0100 [thread overview]
Message-ID: <20251127113416.2740774-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20251127113416.2740774-1-s.hauer@pengutronix.de>
free_device_res() frees dynamically allocated resources allocated during
device lifetime. These are no longer needed when the device is
unregistered, so we can free them in unregister_device(). With this
free_device_res() might be called multiple times, so set
dev->deferred_probe_reason to NULL after freeing it to avoid double
frees.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/base/driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index eefed4b1a5..753e06963b 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -335,6 +335,8 @@ int unregister_device(struct device *old_dev)
if (np && np->dev == old_dev)
np->dev = NULL;
+ free_device_res(old_dev);
+
return 0;
}
EXPORT_SYMBOL(unregister_device);
@@ -352,6 +354,7 @@ void free_device_res(struct device *dev)
free(dev->unique_name);
dev->unique_name = NULL;
free(dev->deferred_probe_reason);
+ dev->deferred_probe_reason = NULL;
}
EXPORT_SYMBOL(free_device_res);
--
2.47.3
next prev parent reply other threads:[~2025-11-27 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 11:34 [PATCH 1/3] driver: call devinfo_del() during free_device_res() Sascha Hauer
2025-11-27 11:34 ` Sascha Hauer [this message]
2025-11-27 11:34 ` [PATCH 3/3] dm: fix memory leak Sascha Hauer
2025-11-28 7:11 ` [PATCH 1/3] driver: call devinfo_del() during free_device_res() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127113416.2740774-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox