mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] sandbox: setjmp: avoid conflict with noinline macro
@ 2025-11-28 10:42 Ahmad Fatoum
  2025-12-01  9:56 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-11-28 10:42 UTC (permalink / raw)
  To: barebox

From: Ahmad Fatoum <a.fatoum@barebox.org>

We define noinline as a macro in <linux/compiler_types.h>, which we
don't yet include here, but might in future with the Kbuild update.

Prepare for that by using the double underscore version instead, which
won't conflict.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 arch/sandbox/os/setjmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sandbox/os/setjmp.c b/arch/sandbox/os/setjmp.c
index cbf1182ed591..787675349643 100644
--- a/arch/sandbox/os/setjmp.c
+++ b/arch/sandbox/os/setjmp.c
@@ -39,7 +39,7 @@ static struct {
  * (from the signal handler when it is not signal handling, read ahead
  * for more information).
  */
-static void __attribute__((noinline, noreturn))
+static void __attribute__((__noinline__, noreturn))
 coroutine_bootstrap(void (*entry)(void))
 {
 	for (;;)
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sandbox: setjmp: avoid conflict with noinline macro
  2025-11-28 10:42 [PATCH] sandbox: setjmp: avoid conflict with noinline macro Ahmad Fatoum
@ 2025-12-01  9:56 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-12-01  9:56 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Fri, 28 Nov 2025 11:42:57 +0100, Ahmad Fatoum wrote:
> We define noinline as a macro in <linux/compiler_types.h>, which we
> don't yet include here, but might in future with the Kbuild update.
> 
> Prepare for that by using the double underscore version instead, which
> won't conflict.
> 
> 
> [...]

Applied, thanks!

[1/1] sandbox: setjmp: avoid conflict with noinline macro
      https://git.pengutronix.de/cgit/barebox/commit/?id=2a15cc630f36 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-01  9:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-28 10:42 [PATCH] sandbox: setjmp: avoid conflict with noinline macro Ahmad Fatoum
2025-12-01  9:56 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox