mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] test: exit directly when invoking QEMU states on non-QEMU targets
@ 2025-11-28 10:50 Ahmad Fatoum
  2025-12-01 10:13 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-11-28 10:50 UTC (permalink / raw)
  To: barebox

From: Ahmad Fatoum <a.fatoum@barebox.org>

Instead of running into a lot of later errors, let's just abort
immediately when trying to use --interactive with a target that doesn't
support it.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 test/strategy.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/strategy.py b/test/strategy.py
index fc65895daece..fcfa2ed48125 100644
--- a/test/strategy.py
+++ b/test/strategy.py
@@ -93,6 +93,9 @@ class BareboxTestStrategy(Strategy):
             if state == "qemu_dump_dtb":
                 self.qemu.machine += f",dumpdtb={self.target.name}.dtb"
 
+            if self.qemu is None:
+                pytest.exit(f"Can't enter {state} for non-QEMU target")
+
             cmd = self.qemu.get_qemu_base_args()
 
             cmd.append("-serial")
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: exit directly when invoking QEMU states on non-QEMU targets
  2025-11-28 10:50 [PATCH] test: exit directly when invoking QEMU states on non-QEMU targets Ahmad Fatoum
@ 2025-12-01 10:13 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-12-01 10:13 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Fri, 28 Nov 2025 11:50:06 +0100, Ahmad Fatoum wrote:
> Instead of running into a lot of later errors, let's just abort
> immediately when trying to use --interactive with a target that doesn't
> support it.
> 
> 

Applied, thanks!

[1/1] test: exit directly when invoking QEMU states on non-QEMU targets
      https://git.pengutronix.de/cgit/barebox/commit/?id=043af2b68ff5 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-01 10:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-28 10:50 [PATCH] test: exit directly when invoking QEMU states on non-QEMU targets Ahmad Fatoum
2025-12-01 10:13 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox