mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] test: populate qemu_bin, even if missing features
@ 2025-11-28 17:21 Ahmad Fatoum
  2025-11-28 17:21 ` [PATCH 2/3] test: arm: qemu-sabrelite: drop -nographic Ahmad Fatoum
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2025-11-28 17:21 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

If the YAML lists no features, the lookup for qemu_bin is prematurely
aborted, even for QEMU environment configs.

Split up the try/except clauses to fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 conftest.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/conftest.py b/conftest.py
index fa088b1cac81..55935f7602f7 100644
--- a/conftest.py
+++ b/conftest.py
@@ -134,9 +134,13 @@ def strategy(request, target, pytestconfig):  # noqa: max-complexity=30
     try:
         main = target.env.config.data["targets"]["main"]
         features = main["features"]
-        qemu_bin = main["drivers"]["QEMUDriver"]["qemu_bin"]
     except KeyError:
         features = []
+
+    try:
+        main = target.env.config.data["targets"]["main"]
+        qemu_bin = main["drivers"]["QEMUDriver"]["qemu_bin"]
+    except KeyError:
         qemu_bin = None
 
     virtio = None
-- 
2.47.3




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-12-01  9:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-28 17:21 [PATCH 1/3] test: populate qemu_bin, even if missing features Ahmad Fatoum
2025-11-28 17:21 ` [PATCH 2/3] test: arm: qemu-sabrelite: drop -nographic Ahmad Fatoum
2025-11-28 17:21 ` [PATCH 3/3] test: arm: qemu-raspi1ap the default multi_v5_v6_defconfig.yaml Ahmad Fatoum
2025-12-01  9:45   ` Sascha Hauer
2025-12-01  9:46     ` Ahmad Fatoum
2025-12-01  9:53 ` [PATCH 1/3] test: populate qemu_bin, even if missing features Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox