From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] fixup! video: fsl-ldb: add ported driver from linux kernel
Date: Fri, 28 Nov 2025 21:09:56 +0100 [thread overview]
Message-ID: <20251128200957.361169-1-a.fatoum@barebox.org> (raw)
video: fsl-ldb: fix unintended implicit fallthroughs
Coverity flagged this fallthroughs and they indeed look unintended.
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
drivers/video/fsl-ldb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fsl-ldb.c b/drivers/video/fsl-ldb.c
index 3fca7867a2a3..0ab720032ccb 100644
--- a/drivers/video/fsl-ldb.c
+++ b/drivers/video/fsl-ldb.c
@@ -220,8 +220,10 @@ static int fsl_ldb_ioctl(struct vpl *vpl, unsigned int port,
break;
case VPL_UNPREPARE:
fsl_ldb_atomic_disable(fsl_ldb);
+ break;
case VPL_PREPARE:
fsl_ldb_atomic_enable(fsl_ldb, data);
+ break;
case VPL_GET_VIDEOMODES:
if (fsl_ldb->modes) {
struct display_timings *timings = data;
--
2.47.3
next reply other threads:[~2025-11-28 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 20:09 Ahmad Fatoum [this message]
2025-12-01 8:54 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128200957.361169-1-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox