From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 08/10] common: elf: use release_region unconditionally
Date: Mon, 5 Jan 2026 09:03:40 +0100 [thread overview]
Message-ID: <20260105080653.3240497-9-a.fatoum@barebox.org> (raw)
In-Reply-To: <20260105080653.3240497-1-a.fatoum@barebox.org>
Given that release_region and release_sdram_region are the same, just
use release_region regardless of whether SDRAM or I/O memory region was
requested.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
common/elf.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/common/elf.c b/common/elf.c
index c68ea0be3fa6..4f4151f722d7 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -18,7 +18,6 @@ struct elf_segment {
struct list_head list;
struct resource *r;
void *phdr;
- bool is_iomem_region;
};
static int elf_request_region(struct elf_image *elf, resource_size_t start,
@@ -40,7 +39,6 @@ static int elf_request_region(struct elf_image *elf, resource_size_t start,
pr_err("Failed to request region: %pa %pa\n", &start, &size);
return -EINVAL;
}
- r->is_iomem_region = true;
}
r->r = r_new;
@@ -56,10 +54,7 @@ static void elf_release_regions(struct elf_image *elf)
struct elf_segment *r, *r_tmp;
list_for_each_entry_safe(r, r_tmp, list, list) {
- if (r->is_iomem_region)
- release_region(r->r);
- else
- release_sdram_region(r->r);
+ release_region(r->r);
list_del(&r->list);
free(r);
}
--
2.47.3
next prev parent reply other threads:[~2026-01-05 8:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 8:03 [PATCH 00/10] bootm: refactor to prepare multiple initrd support Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 01/10] bootm: set image_data::initrd_res at a single place Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 02/10] bootm: fit: split support into dedicated file Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 03/10] bootm: uimage: " Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 04/10] filetype: introduce filetype_fit Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 05/10] bootm: refactor for readability and extensibility Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 06/10] memory: move release_sdram_region into header Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 07/10] resource: make NULL in release_[sdram_]region a no-op Ahmad Fatoum
2026-01-05 8:03 ` Ahmad Fatoum [this message]
2026-01-05 8:03 ` [PATCH 09/10] memory: always print errors on request_sdram_region failure Ahmad Fatoum
2026-01-05 8:03 ` [PATCH 10/10] memory: drop now duplicate request_sdram_region error messages Ahmad Fatoum
2026-01-09 8:20 ` [PATCH 00/10] bootm: refactor to prepare multiple initrd support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105080653.3240497-9-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox