From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: "Claude Sonnet 4.5" <noreply@anthropic.com>
Subject: [PATCH v2 08/21] elf: create elf_open_binary_into()
Date: Tue, 06 Jan 2026 13:53:11 +0100 [thread overview]
Message-ID: <20260106-pbl-load-elf-v2-8-487bc760f045@pengutronix.de> (raw)
In-Reply-To: <20260106-pbl-load-elf-v2-0-487bc760f045@pengutronix.de>
elf_open_binary() returns a dynamically allocated struct elf_image *. We
do not have malloc in the PBL, so for better PBL support create
elf_open_binary_into() which takes a struct elf_image * as argument.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
common/elf.c | 26 +++++++++++++++++++-------
include/elf.h | 1 +
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/common/elf.c b/common/elf.c
index b3cc9b59644aa6e6e029fa44988dbdc0787c42f6..d51c99192f327abc0eb4ca68109bc88c6a451d94 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -318,6 +318,23 @@ static void elf_init_struct(struct elf_image *elf)
elf->filename = NULL;
}
+int elf_open_binary_into(struct elf_image *elf, void *buf)
+{
+ int ret;
+
+ memset(elf, 0, sizeof(*elf));
+ elf_init_struct(elf);
+
+ elf->hdr_buf = buf;
+ ret = elf_check_image(elf, buf);
+ if (ret)
+ return ret;
+
+ elf->entry = elf_hdr_e_entry(elf, elf->hdr_buf);
+
+ return 0;
+}
+
struct elf_image *elf_open_binary(void *buf)
{
int ret;
@@ -327,17 +344,12 @@ struct elf_image *elf_open_binary(void *buf)
if (!elf)
return ERR_PTR(-ENOMEM);
- elf_init_struct(elf);
-
- elf->hdr_buf = buf;
- ret = elf_check_image(elf, buf);
+ ret = elf_open_binary_into(elf, buf);
if (ret) {
free(elf);
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(ret);
}
- elf->entry = elf_hdr_e_entry(elf, elf->hdr_buf);
-
return elf;
}
diff --git a/include/elf.h b/include/elf.h
index 84b98553cff69257f8c2fbfb2e7504a4400e0f53..64574cb4836cd67f54538ad1621d7fc5fbf58f92 100644
--- a/include/elf.h
+++ b/include/elf.h
@@ -410,6 +410,7 @@ static inline size_t elf_get_mem_size(struct elf_image *elf)
return elf->high_addr - elf->low_addr;
}
+int elf_open_binary_into(struct elf_image *elf, void *buf);
struct elf_image *elf_open_binary(void *buf);
struct elf_image *elf_open(const char *filename);
void elf_close(struct elf_image *elf);
--
2.47.3
next prev parent reply other threads:[~2026-01-06 12:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 12:53 [PATCH v2 00/21] PBL: Add PBL ELF loading support with dynamic relocations Sascha Hauer
2026-01-06 12:53 ` [PATCH v2 01/21] elf: only accept images matching the native ELF_CLASS Sascha Hauer
2026-01-06 12:58 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 02/21] elf: build for PBL as well Sascha Hauer
2026-01-06 13:26 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 03/21] elf: add dynamic relocation support Sascha Hauer
2026-01-06 13:51 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 04/21] ARM: implement elf_apply_relocations() for ELF " Sascha Hauer
2026-01-06 13:07 ` Ahmad Fatoum
2026-01-06 14:25 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 05/21] riscv: define generic relocate_image Sascha Hauer
2026-01-06 13:10 ` Ahmad Fatoum
2026-01-06 13:11 ` Sascha Hauer
2026-01-06 12:53 ` [PATCH v2 06/21] riscv: implement elf_apply_relocations() for ELF relocation support Sascha Hauer
2026-01-06 13:11 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 07/21] elf: implement elf_load_inplace() Sascha Hauer
2026-01-06 13:53 ` Ahmad Fatoum
2026-01-06 12:53 ` Sascha Hauer [this message]
2026-01-06 13:55 ` [PATCH v2 08/21] elf: create elf_open_binary_into() Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 09/21] Makefile: add barebox.elf build target Sascha Hauer
2026-01-06 13:13 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 10/21] PBL: allow to link ELF image into PBL Sascha Hauer
2026-01-06 13:18 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 11/21] mmu: add MAP_CACHED_RO mapping type Sascha Hauer
2026-01-06 13:14 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 12/21] mmu: introduce pbl_remap_range() Sascha Hauer
2026-01-06 13:15 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 13/21] ARM: use relative jumps in exception table Sascha Hauer
2026-01-06 13:57 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 14/21] ARM: exceptions: make in-binary exception table const Sascha Hauer
2026-01-06 14:00 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 15/21] ARM: linker script: create separate PT_LOAD segments for text, rodata, and data Sascha Hauer
2026-01-06 14:05 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 16/21] ARM: link ELF image into PBL Sascha Hauer
2026-01-06 14:06 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 17/21] ARM: PBL: setup MMU with proper permissions from ELF segments Sascha Hauer
2026-01-06 14:10 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 18/21] riscv: link ELF image into PBL Sascha Hauer
2026-01-06 14:11 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 19/21] riscv: linker script: create separate PT_LOAD segments for text, rodata, and data Sascha Hauer
2026-01-06 14:12 ` Ahmad Fatoum
2026-01-08 15:25 ` Sascha Hauer
2026-01-06 12:53 ` [PATCH v2 20/21] riscv: Allwinner D1: Drop M-Mode Sascha Hauer
2026-01-06 13:11 ` Ahmad Fatoum
2026-01-06 12:53 ` [PATCH v2 21/21] riscv: add ELF segment-based memory protection with MMU Sascha Hauer
2026-01-06 14:20 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106-pbl-load-elf-v2-8-487bc760f045@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox