mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: "Claude Sonnet 4.5" <noreply@anthropic.com>
Subject: [PATCH v4 15/22] ARM: linker script: create separate PT_LOAD segments for text, rodata, and data
Date: Wed, 14 Jan 2026 13:14:40 +0100	[thread overview]
Message-ID: <20260114-pbl-load-elf-v4-15-0afa78d95a7e@pengutronix.de> (raw)
In-Reply-To: <20260114-pbl-load-elf-v4-0-0afa78d95a7e@pengutronix.de>

Fix the linker scripts to generate three distinct PT_LOAD segments with
correct permissions instead of combining .rodata with .data.

Before this fix, the linker auto-generated only two PT_LOAD segments:
1. Text segment (PF_R|PF_X)
2. Data segment (PF_R|PF_W) - containing .rodata, .data, .bss, etc.

With explicit PHDRS directives, we now generate three segments:
1. text segment (PF_R|PF_X): .text and related code sections
2. rodata segment (PF_R): .rodata and unwind tables
3. data segment (PF_R|PF_W): .data, .bss, and related sections

With this we can setup the MMU properly from outside the ELF binary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/lib32/barebox.lds.S | 35 +++++++++++++++++++++++------------
 arch/arm/lib64/barebox.lds.S | 31 ++++++++++++++++++++-----------
 2 files changed, 43 insertions(+), 23 deletions(-)

diff --git a/arch/arm/lib32/barebox.lds.S b/arch/arm/lib32/barebox.lds.S
index c704dd6d70f3ab157ceb67dfb14760e03f2a5d62..c09899361599dfc8d50b38e35b68c08f48ea9913 100644
--- a/arch/arm/lib32/barebox.lds.S
+++ b/arch/arm/lib32/barebox.lds.S
@@ -7,14 +7,23 @@
 OUTPUT_FORMAT(BAREBOX_OUTPUT_FORMAT)
 OUTPUT_ARCH(BAREBOX_OUTPUT_ARCH)
 ENTRY(start)
+
+PHDRS
+{
+	text PT_LOAD FLAGS(5);		/* PF_R | PF_X */
+	rodata PT_LOAD FLAGS(4);	/* PF_R */
+	dynamic PT_DYNAMIC FLAGS(4);	/* PF_R */
+	data PT_LOAD FLAGS(6);		/* PF_R | PF_W */
+}
+
 SECTIONS
 {
 	. = 0x0;
-	.image_start : { *(.__image_start) }
+	.image_start : { *(.__image_start) } :text
 
 	. = ALIGN(4);
 
-	._text : { *(._text) }
+	._text : { *(._text) } :text
 	.text      :
 	{
 		_stext = .;
@@ -27,7 +36,7 @@ SECTIONS
 		KEEP(*(.text_exceptions*))
 		__exceptions_stop = .;
 		*(.text*)
-	}
+	} :text
 	BAREBOX_BARE_INIT_SIZE
 
 	. = ALIGN(4096);
@@ -35,7 +44,7 @@ SECTIONS
 	.rodata : {
 		*(.rodata*)
 		RO_DATA_SECTION
-	}
+	} :rodata
 
 #ifdef CONFIG_ARM_UNWIND
 	/*
@@ -46,20 +55,22 @@ SECTIONS
 		__start_unwind_idx = .;
 		*(.ARM.exidx*)
 		__stop_unwind_idx = .;
-	}
+	} :rodata
 	.ARM.unwind_tab : {
 		__start_unwind_tab = .;
 		*(.ARM.extab*)
 		__stop_unwind_tab = .;
-	}
+	} :rodata
 #endif
+	.dynamic : { *(.dynamic) } :rodata :dynamic
+
 	. = ALIGN(4096);
+
 	__end_rodata = .;
 	_etext = .;
 	_sdata = .;
 
-	. = ALIGN(4);
-	.data : { *(.data*) }
+	.data : { *(.data*) } :data
 
 	. = .;
 
@@ -69,12 +80,12 @@ SECTIONS
 
 	BAREBOX_EFI_RUNTIME
 
-	.image_end : { *(.__image_end) }
+	.image_end : { *(.__image_end) } :data
 
 	. = ALIGN(4);
-	.__bss_start :  { *(.__bss_start) }
-	.bss : { *(.bss*) }
-	.__bss_stop :  { *(.__bss_stop) }
+	.__bss_start :  { *(.__bss_start) } :data
+	.bss : { *(.bss*) } :data
+	.__bss_stop :  { *(.__bss_stop) } :data
 
 #ifdef CONFIG_ARM_SECURE_MONITOR
 	. = ALIGN(16);
diff --git a/arch/arm/lib64/barebox.lds.S b/arch/arm/lib64/barebox.lds.S
index 5ee5fbc3741e1f7644c00f9b37c0903c27704a3e..1ce2c67df03068e5328a41b394aa1bcbbe63c027 100644
--- a/arch/arm/lib64/barebox.lds.S
+++ b/arch/arm/lib64/barebox.lds.S
@@ -6,14 +6,23 @@
 OUTPUT_FORMAT(BAREBOX_OUTPUT_FORMAT)
 OUTPUT_ARCH(BAREBOX_OUTPUT_ARCH)
 ENTRY(start)
+
+PHDRS
+{
+	text PT_LOAD FLAGS(5);		/* PF_R | PF_X */
+	rodata PT_LOAD FLAGS(4);	/* PF_R */
+	dynamic PT_DYNAMIC FLAGS(4);	/* PF_R */
+	data PT_LOAD FLAGS(6);		/* PF_R | PF_W */
+}
+
 SECTIONS
 {
 	. = 0x0;
 
-	.image_start : { *(.__image_start) }
+	.image_start : { *(.__image_start) } :text
 
 	. = ALIGN(4);
-	._text : { *(._text) }
+	._text : { *(._text) } :text
 	.text      :
 	{
 		_stext = .;
@@ -22,7 +31,7 @@ SECTIONS
 		*(.text_bare_init*)
 		__bare_init_end = .;
 		*(.text*)
-	}
+	} :text
 	BAREBOX_BARE_INIT_SIZE
 
 	. = ALIGN(4096);
@@ -30,7 +39,9 @@ SECTIONS
 	.rodata : {
 		*(.rodata*)
 		RO_DATA_SECTION
-	}
+	} :rodata
+
+	.dynamic : { *(.dynamic) } :rodata :dynamic
 
 	. = ALIGN(4096);
 
@@ -38,20 +49,18 @@ SECTIONS
 	_etext = .;
 	_sdata = .;
 
-	.data : { *(.data*) }
-
-	BAREBOX_RELOCATION_TABLE
+	.data : { *(.data*) } :data
 
 	_edata = .;
 
 	BAREBOX_EFI_RUNTIME
 
-	.image_end : { *(.__image_end) }
+	.image_end : { *(.__image_end) } :data
 
 	. = ALIGN(4);
-	.__bss_start :  { *(.__bss_start) }
-	.bss : { *(.bss*) }
-	.__bss_stop :  { *(.__bss_stop) }
+	.__bss_start :  { *(.__bss_start) } :data
+	.bss : { *(.bss*) } :data
+	.__bss_stop :  { *(.__bss_stop) } :data
 	_end = .;
 	_barebox_image_size = __bss_start;
 }

-- 
2.47.3




  parent reply	other threads:[~2026-01-14 12:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 12:14 [PATCH v4 00/22] PBL: Add PBL ELF loading support with dynamic relocations Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 01/22] Makefile.compiler: add objcopy-option Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 02/22] elf: only accept images matching the native ELF_CLASS Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 03/22] elf: build for PBL as well Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 04/22] elf: add elf segment iterator Sascha Hauer
2026-01-14 13:45   ` Ahmad Fatoum
2026-01-14 12:14 ` [PATCH v4 05/22] elf: add dynamic relocation support Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 06/22] ARM: implement elf_apply_relocations() for ELF " Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 07/22] riscv: define generic relocate_image Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 08/22] riscv: implement elf_apply_relocations() for ELF relocation support Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 09/22] elf: implement elf_load_inplace() Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 10/22] elf: create elf_open_binary_into() Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 11/22] Makefile: add vmbarebox build target Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 12/22] PBL: allow to link ELF image into PBL Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 13/22] mmu: add MAP_CACHED_RO mapping type Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 14/22] ARM: drop arm_fixup_vectors() Sascha Hauer
2026-01-14 12:14 ` Sascha Hauer [this message]
2026-01-14 15:06   ` [PATCH v4 15/22] ARM: linker script: create separate PT_LOAD segments for text, rodata, and data Ahmad Fatoum
2026-01-14 12:14 ` [PATCH v4 16/22] ARM: link ELF image into PBL Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 17/22] ARM: cleanup barebox proper entry Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 18/22] ARM: PBL: setup MMU with proper permissions from ELF segments Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 19/22] riscv: linker script: create separate PT_LOAD segments for text, rodata, and data Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 20/22] riscv: link ELF image into PBL Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 21/22] riscv: Allwinner D1: Drop M-Mode Sascha Hauer
2026-01-14 12:14 ` [PATCH v4 22/22] riscv: add ELF segment-based memory protection with MMU Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114-pbl-load-elf-v4-15-0afa78d95a7e@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=noreply@anthropic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox