mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: [PATCH v2 4/5] ARM: i.MX8M: cosmetic cleanup
Date: Wed, 14 Jan 2026 13:00:58 +0100	[thread overview]
Message-ID: <20260114120221.941836-4-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260114120221.941836-1-a.fatoum@pengutronix.de>

From: Marco Felsch <m.felsch@pengutronix.de>

Rename the local imx8m_atf_start_bl31() to imx8m_tfa_start_bl31() since
the official naming is Trusted-Firmware A (TF-A) and not ARM Trusted
Firmware which was the former name.

While on it rename the parameters to make it clear what firmware
component is passed and align the function documentation with the
reality.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v1 - > v2:
  - split off preparatory patch from
    https://lore.barebox.org/barebox/20251110-v2025-09-0-topic-optee-of-handling-v1-0-8f0625ac5471@pengutronix.de/T/#t
---
 arch/arm/mach-imx/atf.c | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/arch/arm/mach-imx/atf.c b/arch/arm/mach-imx/atf.c
index 11fe0334059d..df2991f47827 100644
--- a/arch/arm/mach-imx/atf.c
+++ b/arch/arm/mach-imx/atf.c
@@ -19,11 +19,11 @@
 #include <mach/imx/xload.h>
 
 /**
- * imx8m_atf_load_bl31 - Load ATF BL31 blob and transfer control to it
+ * imx8m_tfa_start_bl31 - Load TF-A BL31 blob and transfer control to it
  *
- * @fw:		Pointer to the BL31 blob
- * @fw_size:	Size of the BL31 blob
- * @atf_dest:	Place where the BL31 is copied to and executed
+ * @tfa:	Pointer to the BL31 blob
+ * @tfa_size:	Size of the BL31 blob
+ * @tfa_dest:	Place where the BL31 is copied to and executed
  *
  * This function:
  *
@@ -37,12 +37,12 @@
  *     3. Transfers control to BL31
  */
 
-static __noreturn void imx8m_atf_start_bl31(const void *fw, size_t fw_size, void *atf_dest)
+static __noreturn void imx8m_tfa_start_bl31(const void *tfa_bin, size_t tfa_size, void *tfa_dest)
 {
-	void __noreturn (*bl31)(void) = atf_dest;
+	void __noreturn (*bl31)(void) = tfa_dest;
 	int ret;
 
-	BUG_ON(fw_size > MX8M_ATF_BL31_SIZE_LIMIT);
+	BUG_ON(tfa_size > MX8M_ATF_BL31_SIZE_LIMIT);
 
 	if (IS_ENABLED(CONFIG_FSL_CAAM_RNG_PBL_INIT)) {
 		ret = imx_early_caam_init(MX8M_CAAM_BASE_ADDR);
@@ -52,10 +52,10 @@ static __noreturn void imx8m_atf_start_bl31(const void *fw, size_t fw_size, void
 			pr_debug("CAAM early init successful\n");
 	}
 
-	memcpy(bl31, fw, fw_size);
+	memcpy(bl31, tfa_bin, tfa_size);
 
 	asm volatile("msr sp_el2, %0" : :
-		     "r" (atf_dest - 16) :
+		     "r" (tfa_dest - 16) :
 		     "cc");
 	bl31();
 	__builtin_unreachable();
@@ -176,7 +176,7 @@ __noreturn void __imx8mm_load_and_start_image_via_tfa(void *bl33)
 		get_builtin_firmware(imx8mm_bl31_bin, &bl31, &bl31_size);
 	}
 
-	imx8m_atf_start_bl31(bl31, bl31_size, (void *)MX8MM_ATF_BL31_BASE_ADDR);
+	imx8m_tfa_start_bl31(bl31, bl31_size, (void *)MX8MM_ATF_BL31_BASE_ADDR);
 }
 
 void imx8mp_load_bl33(void *bl33)
@@ -250,10 +250,9 @@ __noreturn void __imx8mp_load_and_start_image_via_tfa(void *bl33)
 		get_builtin_firmware(imx8mp_bl31_bin, &bl31, &bl31_size);
 	}
 
-	imx8m_atf_start_bl31(bl31, bl31_size, (void *)MX8MP_ATF_BL31_BASE_ADDR);
+	imx8m_tfa_start_bl31(bl31, bl31_size, (void *)MX8MP_ATF_BL31_BASE_ADDR);
 }
 
-
 void imx8mn_load_bl33(void *bl33)
 {
 	enum bootsource src;
@@ -325,7 +324,7 @@ __noreturn void __imx8mn_load_and_start_image_via_tfa(void *bl33)
 		get_builtin_firmware(imx8mn_bl31_bin, &bl31, &bl31_size);
 	}
 
-	imx8m_atf_start_bl31(bl31, bl31_size, (void *)MX8MN_ATF_BL31_BASE_ADDR);
+	imx8m_tfa_start_bl31(bl31, bl31_size, (void *)MX8MN_ATF_BL31_BASE_ADDR);
 }
 
 void imx8mq_load_bl33(void *bl33)
@@ -393,7 +392,7 @@ __noreturn void __imx8mq_load_and_start_image_via_tfa(void *bl33)
 		get_builtin_firmware(imx8mq_bl31_bin, &bl31, &bl31_size);
 	}
 
-	imx8m_atf_start_bl31(bl31, bl31_size, (void *)MX8MQ_ATF_BL31_BASE_ADDR);
+	imx8m_tfa_start_bl31(bl31, bl31_size, (void *)MX8MQ_ATF_BL31_BASE_ADDR);
 }
 
 void __noreturn imx93_load_and_start_image_via_tfa(void)
-- 
2.47.3




  parent reply	other threads:[~2026-01-14 12:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 12:00 [PATCH v2 1/5] pbl: fdt: fix fdt_fixup_mem error handling Ahmad Fatoum
2026-01-14 12:00 ` [PATCH v2 2/5] pbl: compressed-dtb: add missing includes Ahmad Fatoum
2026-01-14 12:00 ` [PATCH v2 3/5] ARM: atf: add missing includes in atf_common.h Ahmad Fatoum
2026-01-14 12:00 ` Ahmad Fatoum [this message]
2026-01-14 12:00 ` [PATCH v2 5/5] pbl: string: add strncmp Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114120221.941836-4-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox