From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 1/2] efi: loader: protocol: gop: guard behind CONFIG_EFI_LOADER_GOP
Date: Tue, 20 Jan 2026 11:49:52 +0100 [thread overview]
Message-ID: <20260120104957.41978-1-a.fatoum@barebox.org> (raw)
The gop protocol implementation uses fb_open, which is only available
with CONFIG_IMAGE_RENDERER=y.
Add a dedicated symbol for it and have it select CONFIG_IMAGE_RENDERER=y
to fix link errors for configurations with CONFIG_VIDEO=y, but no
CONFIG_IMAGE_RENDERER.
Fixes: d040f49ad0b3 ("efi: loader: protocol: add graphical output protocol support")
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
efi/loader/protocols/Kconfig | 18 ++++++++++++++++++
efi/loader/protocols/Makefile | 2 +-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/efi/loader/protocols/Kconfig b/efi/loader/protocols/Kconfig
index ba6f562b7585..ad7896065ab7 100644
--- a/efi/loader/protocols/Kconfig
+++ b/efi/loader/protocols/Kconfig
@@ -2,6 +2,24 @@
menu "UEFI protocol support"
+config EFI_LOADER_GOP
+ bool "Graphics output protocol"
+ depends on VIDEO
+ select IMAGE_RENDERER
+ default y
+ help
+ The graphics output protocol (GOP) provides UEFI applications access
+ to a framebuffer for graphical output. This allows booting of UEFI
+ applications and operating systems that require graphics support.
+
+ The protocol exposes the video mode information and framebuffer
+ details to UEFI payloads, enabling them to render graphics, display
+ boot menus, and provide visual feedback during boot.
+
+ If you have video support enabled and want to boot UEFI applications
+ that require graphics (such as GRUB with graphical menus or Linux
+ with EFIFB), say Y here.
+
config EFI_LOADER_HII
bool "HII protocols"
default y
diff --git a/efi/loader/protocols/Makefile b/efi/loader/protocols/Makefile
index a323927b89e3..d0b55bde4644 100644
--- a/efi/loader/protocols/Makefile
+++ b/efi/loader/protocols/Makefile
@@ -2,7 +2,7 @@
obj-$(CONFIG_FS) += file.o
obj-$(CONFIG_DISK) += disk.o
-obj-$(CONFIG_VIDEO) += gop.o
+obj-$(CONFIG_EFI_LOADER_GOP) += gop.o
obj-$(CONFIG_CONSOLE_FULL) += console.o
obj-$(CONFIG_EFI_LOADER_HII) += hii.o hii_config.o
obj-$(CONFIG_EFI_LOADER_UNICODE_COLLATION_PROTOCOL2) += unicode_collation.o
--
2.47.3
next reply other threads:[~2026-01-20 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 10:49 Ahmad Fatoum [this message]
2026-01-20 10:49 ` [PATCH 2/2] efi: loader: remove dependency on LIBFDT Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120104957.41978-1-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox