mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: mfe@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/2] arm: dts: rk356x: rock3a: disable pcie3x2
Date: Wed, 21 Jan 2026 12:31:28 +0100	[thread overview]
Message-ID: <20260121113234.1438699-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260121113234.1438699-1-a.fatoum@pengutronix.de>

The board hangs occasionally on PCI probe after:

  phy7: lane number 0, val 1

On other boots, it continues to:

  rockchip-dw-pcie 3c0800000.pcie@fe280000.of: Phy link never came up

In both cases, the hang affects the second PCIe host controller
to probe and the first probe never hangs:

  rockchip-dw-pcie 3c0000000.pcie@fe260000.of: Phy link never came up

This hang happens on the very first read access to the PCI controller
at register PCIE_ATU_VIEWPORT. Reading Linux code, the first access
seems to be to PCIE_VERSION_NUMBER (0x8F8), but accessing that in
barebox equally hangs from time to time.

My board doesn't have any PCIe devices connected and this hang
doesn't happen in Linux and doesn't happen on the QNAP
TS433-eU, which is also RK3568, but actually has PCIe devices, which are
probed normally.

Disable the device in barebox, so the board is usable with
rockchip_v8_defconfig, which enables the PCI driver.
barebox,status is used, so the Linux device tree is not affected.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - add short comment explaining why we disable this device in particular
---
 arch/arm/dts/rk3568-rock-3a.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/dts/rk3568-rock-3a.dts b/arch/arm/dts/rk3568-rock-3a.dts
index bcbfab14a580..4834a85b367a 100644
--- a/arch/arm/dts/rk3568-rock-3a.dts
+++ b/arch/arm/dts/rk3568-rock-3a.dts
@@ -55,3 +55,8 @@ environment_sd: partition@408000 {
 		};
 	};
 };
+
+/* Device driver probe occasionally hangs, but pcie2x1 is fine... */
+&pcie3x2 {
+	barebox,status = "disabled";
+};
-- 
2.47.3




  reply	other threads:[~2026-01-21 11:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 11:31 [PATCH 1/2] of: base: add new barebox,status property Ahmad Fatoum
2026-01-21 11:31 ` Ahmad Fatoum [this message]
2026-01-21 12:00   ` [PATCH 2/2] arm: dts: rk356x: rock3a: disable pcie3x2 Marco Felsch
2026-01-21 11:33 ` [PATCH 1/2] of: base: add new barebox,status property Ahmad Fatoum
2026-01-21 11:59 ` Marco Felsch
  -- strict thread matches above, loose matches on Subject: below --
2026-01-20 18:13 Ahmad Fatoum
2026-01-20 18:13 ` [PATCH 2/2] arm: dts: rk356x: rock3a: disable pcie3x2 Ahmad Fatoum
2026-01-21  0:07   ` Marco Felsch
2026-01-21  7:52     ` Ahmad Fatoum
2026-01-21  9:16       ` Marco Felsch
2026-01-21  9:41         ` Ahmad Fatoum
2026-01-21 10:15           ` Marco Felsch
2026-01-21 11:02             ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121113234.1438699-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mfe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox