From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 26 Jan 2026 11:42:39 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkK3M-005Vrm-13 for lore@lore.pengutronix.de; Mon, 26 Jan 2026 11:42:39 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vkK3L-0001uS-Bz for lore@pengutronix.de; Mon, 26 Jan 2026 11:42:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=xKC8rruvPFsQwVQU4FLEx2zo7qPROXgsYx8qTT6gzR0=; b=fynvqnJP6spHNROiwx2khGIhCX 4ic73Ycn3EzxEjkmr9wS0Ra3OTeB6YlC8OAc/THbRU6V0swYEy3BrpuxO2hIcgjsVGS8/Wwo81FUe uKcIE2kZJr8Xh6rEB8EM9tUj0ffCP4WGjx0OFehoPTuDwYWg43JD8FfmsiGcx2rqi9JiK7B5bluXV 3+0oIdeybhaNWO6B5d2F7thzGRGF2JLSse4O35t3weg3n5MqFG8cfUp/yQtUei+shLT8O6kDYxmFM Z8JoQr0Qof8rZ4KY6D58QwhG3GSWi01B4UB51JKkSrZNPk4IjtauvErW+Z/8FbfC9hunDxA4xLRW4 qeRIO55w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkK2i-0000000CJAZ-1XgW; Mon, 26 Jan 2026 10:42:00 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkK2f-0000000CJAE-0zkA for barebox@lists.infradead.org; Mon, 26 Jan 2026 10:41:58 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vkK2c-0001oD-Tq; Mon, 26 Jan 2026 11:41:54 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkK2d-002ZBk-1G; Mon, 26 Jan 2026 11:41:54 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vkK2d-00000002QWM-0Yc4; Mon, 26 Jan 2026 11:41:54 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Mon, 26 Jan 2026 11:41:37 +0100 Message-ID: <20260126104153.547505-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260126_024157_296707_BAE716ED X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,SUBJECT_IN_BLACKLIST, SUBJECT_IN_BLOCKLIST autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master] net: phy: mdio_bus: fix freeing of cdev name before devfs_remove X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) devfs_remove acces struct cdev::name to do an unlink on the path in /dev. This leads to a use-after-free inside mdio_bus_remove. Reorder the free after devfs_remove to fix this. This is the way that other drivers in tree that have /free.*cdev(\.|->)name/ do it. Issue was detected by KASAN being active during kernel boot. Signed-off-by: Ahmad Fatoum --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index a7eda3f84a11..1381f70f1cf8 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -610,8 +610,8 @@ static void mdio_bus_remove(struct device *_dev) if (drv->remove) drv->remove(dev); - free(dev->cdev.name); devfs_remove(&dev->cdev); + free(dev->cdev.name); bus->phy_map[dev->addr] = NULL; } -- 2.47.3