From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: mfe@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>,
"Claude Sonnet 4.5" <noreply@anthropic.com>
Subject: [PATCH master 2/2] FIT: fuzz: fix reference count underflow
Date: Mon, 26 Jan 2026 11:44:30 +0100 [thread overview]
Message-ID: <20260126104433.765071-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260126104433.765071-1-a.fatoum@pengutronix.de>
Now that FIT images are reference counted, we need to initialize the
count to 1, otherwise __fit_close will underflow it.
Reported-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixes: f3aadb274abe ("FIT: add support to cache opened fit images")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Issue was found by Claude while reviewing the previous patch
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/image-fit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/image-fit.c b/common/image-fit.c
index b5d0e2e5381f..26bd8e265b25 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1120,6 +1120,8 @@ static int fuzz_fit(const u8 *data, size_t size)
handle.fit = data;
handle.fit_alloc = NULL;
+ refcount_set(&handle.users, 1);
+
ret = fit_do_open(&handle);
if (ret)
goto out;
--
2.47.3
next prev parent reply other threads:[~2026-01-26 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:44 [PATCH master 1/2] FIT: fix double free issue with >1 reference count Ahmad Fatoum
2026-01-26 10:44 ` Ahmad Fatoum [this message]
2026-01-26 12:03 ` Marco Felsch
2026-01-27 7:56 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126104433.765071-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mfe@pengutronix.de \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox