From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, "Claude Sonnet 4.5" <noreply@anthropic.com>
Subject: Re: [PATCH master 1/2] FIT: fix double free issue with >1 reference count
Date: Mon, 26 Jan 2026 13:03:11 +0100 [thread overview]
Message-ID: <20260126120311.ozxu7wrmckimlokk@pengutronix.de> (raw)
In-Reply-To: <20260126104433.765071-1-a.fatoum@pengutronix.de>
On 26-01-26, Ahmad Fatoum wrote:
> fit_open() was recently changed to be reference counted. When the FIT is
> already open, a handle will be returned with the canonical filename
> being the only allocation incurred.
>
> fit_close() however unconditionally frees the handle without regards to
> the reference count.
>
> Fix this and while at it, fix the memory leak for the canonical filename
> as well.
>
> Reported-by: Claude Sonnet 4.5 <noreply@anthropic.com>
> Fixes: f3aadb274abe ("FIT: add support to cache opened fit images")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
next prev parent reply other threads:[~2026-01-26 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:44 Ahmad Fatoum
2026-01-26 10:44 ` [PATCH master 2/2] FIT: fuzz: fix reference count underflow Ahmad Fatoum
2026-01-26 12:03 ` Marco Felsch [this message]
2026-01-27 7:56 ` [PATCH master 1/2] FIT: fix double free issue with >1 reference count Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126120311.ozxu7wrmckimlokk@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox