mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] efi: loader: reduce warning about non-persistent EFI variables to notice
@ 2026-01-27 15:36 Ahmad Fatoum
  2026-01-30 12:42 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-01-27 15:36 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

When booting an EFI-stubbed kernel outside of an ESP, we always get:

  WARNING: efi-loader: var-file: Cannot persist EFI variables without
  system partition

A warning is arguably a bit harsh, because one still benefits from
keeping the MMU enabled and the other EFI runtime services, so bump to a
notice log level instead.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 efi/loader/efi_var_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/efi/loader/efi_var_file.c b/efi/loader/efi_var_file.c
index 652354693ae7..e0dec999b779 100644
--- a/efi/loader/efi_var_file.c
+++ b/efi/loader/efi_var_file.c
@@ -59,7 +59,7 @@ efi_status_t efi_var_to_file(void)
 	dirfd = efiloader_esp_mount_dir();
 	if (dirfd < 0) {
 		if (!once) {
-			pr_warn("Cannot persist EFI variables without system partition\n");
+			pr_notice("Cannot persist EFI variables without system partition\n");
 			once = true;
 		}
 		efiret = EFI_NO_MEDIA;
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] efi: loader: reduce warning about non-persistent EFI variables to notice
  2026-01-27 15:36 [PATCH] efi: loader: reduce warning about non-persistent EFI variables to notice Ahmad Fatoum
@ 2026-01-30 12:42 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-01-30 12:42 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 27 Jan 2026 16:36:38 +0100, Ahmad Fatoum wrote:
> When booting an EFI-stubbed kernel outside of an ESP, we always get:
> 
>   WARNING: efi-loader: var-file: Cannot persist EFI variables without
>   system partition
> 
> A warning is arguably a bit harsh, because one still benefits from
> keeping the MMU enabled and the other EFI runtime services, so bump to a
> notice log level instead.
> 
> [...]

Applied, thanks!

[1/1] efi: loader: reduce warning about non-persistent EFI variables to notice
      https://git.pengutronix.de/cgit/barebox/commit/?id=c15db8e3b01c (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-30 12:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-27 15:36 [PATCH] efi: loader: reduce warning about non-persistent EFI variables to notice Ahmad Fatoum
2026-01-30 12:42 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox