mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] ci: container: set LLVM_SUFFIX instead of CROSS_COMPILE_llvm
Date: Tue, 10 Feb 2026 12:43:54 +0100	[thread overview]
Message-ID: <20260210114355.1357220-1-a.fatoum@pengutronix.de> (raw)

To compile with LLVM inside the container, the expectation so far was
that the user would do:

  export LLVM="${CROSS_COMPILE_llvm}"

This is confusing as CROSS_COMPILE is gcc-only and needlessly
cumbersome. The Makefile also accepts LLVM_PREFIX and LLVM_SUFFIX
variables. The utilities are already in PATH, so just set LLVM_SUFFIX to
the correct. -${LLVM_VERSION} suffix.

Users will then have to only set

  export LLVM=1

and GCC builds continue to be unaffected as LLVM_SUFFIX/PREFIX are only
evaluated if ${LLVM} is non-empty.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 test/Containerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/Containerfile b/test/Containerfile
index 6e4515f7d582..fc1d8f5f9671 100644
--- a/test/Containerfile
+++ b/test/Containerfile
@@ -107,7 +107,7 @@ ENV CROSS_COMPILE_powerpc=/opt/gcc-${GCC_VERSION}-nolibc/powerpc-linux/bin/power
 ENV CROSS_COMPILE_riscv=/opt/gcc-${GCC_VERSION}-nolibc/riscv64-linux/bin/riscv64-linux-
 ENV CROSS_COMPILE_kvx=/opt/gcc-kalray-kvx-v5.2.0/bin/kvx-elf-
 
-ENV CROSS_COMPILE_llvm=-${LLVM_VERSION}
+ENV LLVM_SUFFIX=-${LLVM_VERSION}
 # Workaround for https://github.com/llvm/llvm-project/issues/112458
 RUN ln -Ts /usr/lib/llvm-${LLVM_VERSION}/lib/clang/${LLVM_VERSION}/lib/linux/ \
            /usr/lib/llvm-${LLVM_VERSION}/lib/clang/${LLVM_VERSION}/lib/x86_64-pc-linux-gnu
-- 
2.47.3




             reply	other threads:[~2026-02-10 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 11:43 Ahmad Fatoum [this message]
2026-02-11  9:34 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210114355.1357220-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox